Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webcamoid: init at 8.7.1 #86261

Merged
merged 2 commits into from May 23, 2020
Merged

webcamoid: init at 8.7.1 #86261

merged 2 commits into from May 23, 2020

Conversation

@robaca
Copy link
Contributor

robaca commented Apr 28, 2020

Expression for packaging webcamoid (https://webcamoid.github.io/)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@robaca
Copy link
Contributor Author

robaca commented Apr 29, 2020

related to package request #84890

@robaca robaca mentioned this pull request Apr 29, 2020
@robaca
Copy link
Contributor Author

robaca commented May 15, 2020

Is there missing something in the MR to be eligible for a review?

Copy link
Contributor

aanderse left a comment

Just a large backlog of PRs, unfortunately. I haven't looked at the qt stuff in a bit so I can't offer more advice, but I'm a bit confused by the preFixup and INSTALLQMLDIR bit (not saying it is wrong, I'm really just not familiar).

Maybe a wonderful person who is much more knowledgeable than myself and volunteers themselves for PR reviews, like @jonringer, would be willing to take a look.

maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/applications/video/webcamoid/default.nix Outdated Show resolved Hide resolved
pkgs/applications/video/webcamoid/default.nix Outdated Show resolved Hide resolved
pkgs/applications/video/webcamoid/default.nix Outdated Show resolved Hide resolved
@robaca robaca force-pushed the robaca:webcamoid branch from 907aef3 to 536c654 May 22, 2020
@robaca robaca requested a review from aanderse May 22, 2020
@aanderse
Copy link
Contributor

aanderse commented May 22, 2020

@GrahamcOfBorg build webcamoid

@aanderse
Copy link
Contributor

aanderse commented May 22, 2020

@robaca can you please squash the last 2 commits into a single and have it as webcamoid: init at 8.7.1 as per CONTRIBUTING.MD.

@robaca robaca force-pushed the robaca:webcamoid branch from 536c654 to f3050a6 May 22, 2020
@robaca
Copy link
Contributor Author

robaca commented May 22, 2020

@aanderse I fixed the commit history as requested.

@aanderse
Copy link
Contributor

aanderse commented May 23, 2020

@robaca thanks for you patience in all this and the great new package. Welcome to the team! 🎉

@aanderse aanderse merged commit dacd1e4 into NixOS:master May 23, 2020
18 checks passed
18 checks passed
editorconfig editorconfig
Details
webcamoid on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f3050a6"; rev="f3050a68318a07c6b88c6052df48e8147388dfcd"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f3050a6"; rev="f3050a68318a07c6b88c6052df48e8147388dfcd"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f3050a6"; rev="f3050a68318a07c6b88c6052df48e8147388dfcd"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f3050a6"; rev="f3050a68318a07c6b88c6052df48e8147388dfcd"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f3050a6"; rev="f3050a68318a07c6b88c6052df48e8147388dfcd"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f3050a6"; rev="f3050a68318a07c6b88c6052df48e8147388dfcd"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f3050a6"; rev="f3050a68318a07c6b88c6052df48e8147388dfcd"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
webcamoid on aarch64-linux Success
Details
webcamoid on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.