Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
python3Packages.python-gitlab: 1.15.0 -> 2.2.0 #86269
Motivation for this change
2 packages built:
Thanks for the feedback!
What part of CONTRIBUTING.md did I not follow? (Honest question. I just read it again and can't determine where I went afoul of it.)
Does that manual section mandate squashing of all commits? The only rule towards that direction seems to be
None of my commits here are of "oh, forgot to insert whitespace" nature, as far as I can tell.
That manual section also says:
That's what I tried to do here. Note that I didn't make separate commits for all versions since 1.15.0. My reasons for the commits are as follows:
Yes, these are many bumps, but I think having them in the history is worthwhile. If you maintain that they are too many, I'd like to at least preserve be60e99 & a27308c (and squash 7cceb71, 548bb89 and a770650 to one single commit, resulting in a total of 3 commits), unless you insist they be all squashed into only one commit.
Does 3 commits sound good to you?
make most sense, if not all 5 commits shall be preserved.
Alright, I've squashed the four version bump commits into one, but left the re-format commit as-is.
Not quite sure what to make of that. If you require changes for an approving review, please give actionable feedback. If however the PR just isn't to your best liking, but you find it objectively acceptable, please state that clearly.
To me, you're doing a version bump, if you have a series of 4 version bumps, why not collapse it into a single version bump? If there was a regression in this package, then having the many version bumps doesn't really help, because you are trying to triage regressions from master. So having an intermediate commit, which never had a release on that package, seems to add noise when doing a