Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnumake: 4.2.1 -> 4.3 #86293

Merged
merged 1 commit into from Jul 2, 2020
Merged

gnumake: 4.2.1 -> 4.3 #86293

merged 1 commit into from Jul 2, 2020

Conversation

@chkno
Copy link
Member

chkno commented Apr 29, 2020

Motivation for this change

A new version of gnumake is available. Changelog

Things done

This also cleans up some cruft about tracking multiple versions of make. The last time a package needed a make version override was in edee502 in Apr 2015.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Maintainer: @vrthra

@ofborg ofborg bot requested review from andir, edolstra, lovek323, np and vrthra Apr 29, 2020
@FRidh FRidh added this to WIP in Staging via automation May 1, 2020
@FRidh FRidh moved this from WIP to Needs review in Staging May 1, 2020
@Ma27 Ma27 requested a review from fpletz May 6, 2020
@FRidh FRidh merged commit 0cfe9f3 into NixOS:staging Jul 2, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
gnumake, gnumake.passthru.tests on aarch64-linux Success
Details
gnumake, gnumake.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="12474a1"; rev="12474a1f342f019c1167892b36b8c3ab727cd0db"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="12474a1"; rev="12474a1f342f019c1167892b36b8c3ab727cd0db"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="12474a1"; rev="12474a1f342f019c1167892b36b8c3ab727cd0db"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="12474a1"; rev="12474a1f342f019c1167892b36b8c3ab727cd0db"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="12474a1"; rev="12474a1f342f019c1167892b36b8c3ab727cd0db"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="12474a1"; rev="12474a1f342f019c1167892b36b8c3ab727cd0db"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="12474a1"; rev="12474a1f342f019c1167892b36b8c3ab727cd0db"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Staging automation moved this from Needs review to Done Jul 2, 2020
vcunat added a commit that referenced this pull request Jul 6, 2020
This is almost a revert of commit 0cfe9f3 (PR #86293).  Version 4.3
https://lists.gnu.org/archive/html/info-gnu/2020-01/msg00004.html
brought some incompatibilities, so this will be useful for shorter-term
workarounds.
@vcunat
Copy link
Member

vcunat commented Jul 6, 2020

The last time a package needed a make version override was in edee502 in Apr 2015.

Well, this bump actually forced the need for make version override :-)
(for now just bb9f138, but I expect more will come)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.