Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helmsman: init at 3.3.0 #86328

Merged
merged 2 commits into from May 13, 2020
Merged

helmsman: init at 3.3.0 #86328

merged 2 commits into from May 13, 2020

Conversation

@Lynty
Copy link
Contributor

Lynty commented Apr 29, 2020

Motivation for this change

Adds https://github.com/Praqma/helmsman, a useful tool which allows you to automate the deployment/management of your Helm charts from version controlled code.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

oxzi left a comment

Thanks a lot for your first contribution to the nixpkgs!

Perhaps you want to change the addressed lines.

@oxzi oxzi self-requested a review Apr 29, 2020
@oxzi
oxzi approved these changes Apr 29, 2020
Copy link
Member

oxzi left a comment

LGTM

Copy link
Contributor

jonringer left a comment

otherwise LGTM

meta = {
description = "Helm Charts (k8s applications) as Code tool";
homepage = "https://github.com/Praqma/helmsman";
license = lib.licenses.mit;
maintainers = with lib.maintainers; [ lynty ];
platforms = lib.platforms.unix;
Comment on lines 16 to 21

This comment has been minimized.

@jonringer

jonringer May 12, 2020 Contributor

just to make it a little more concise

Suggested change
meta = {
description = "Helm Charts (k8s applications) as Code tool";
homepage = "https://github.com/Praqma/helmsman";
license = lib.licenses.mit;
maintainers = with lib.maintainers; [ lynty ];
platforms = lib.platforms.unix;
meta = with lib; {
description = "Helm Charts (k8s applications) as Code tool";
homepage = "https://github.com/Praqma/helmsman";
license = licenses.mit;
maintainers = with maintainers; [ lynty ];
platforms = platforms.unix;
@jonringer
Copy link
Contributor

jonringer commented May 12, 2020

@Lynty thanks again for opening your first PR. PR volume is super high, and hard to get to everyone

Copy link
Contributor

jonringer left a comment

LGTM

Result of nixpkgs-review pr 86328 1

1 package built:
- helmsman

@jonringer jonringer merged commit c85f0a1 into NixOS:master May 13, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="80f1e13"; rev="80f1e13ff287cb28b2cbdbd8dbda46fa496f83d9"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="80f1e13"; rev="80f1e13ff287cb28b2cbdbd8dbda46fa496f83d9"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="80f1e13"; rev="80f1e13ff287cb28b2cbdbd8dbda46fa496f83d9"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="80f1e13"; rev="80f1e13ff287cb28b2cbdbd8dbda46fa496f83d9"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="80f1e13"; rev="80f1e13ff287cb28b2cbdbd8dbda46fa496f83d9"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="80f1e13"; rev="80f1e13ff287cb28b2cbdbd8dbda46fa496f83d9"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="80f1e13"; rev="80f1e13ff287cb28b2cbdbd8dbda46fa496f83d9"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
helmsman, helmsman.passthru.tests on aarch64-linux Success
Details
helmsman, helmsman.passthru.tests on x86_64-linux Success
Details
@Lynty Lynty deleted the Lynty:helmsman-init branch May 13, 2020
@Lynty Lynty mentioned this pull request May 19, 2020
5 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.