Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixpkgs-fmt: fix erroneous debug output #86335

Merged
merged 1 commit into from May 2, 2020
Merged

Conversation

@cole-h
Copy link
Member

cole-h commented Apr 29, 2020

Prior to this, when used in conjunction with e.g. format-all-mode,
garbage like

node: NODE_STRING@[8934; 9139), indent: IndentLevel { level: 3, alignment: 0 }

would be written to the file.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@pbogdan
Copy link
Member

pbogdan commented Apr 29, 2020

While personally I reverted back to 0.7.0 perhaps it might be worth checking if upstream would be willing to cut a new release? Without this patch 0.8.0 was rendered pretty much unusable…

@cole-h
Copy link
Member Author

cole-h commented Apr 29, 2020

Done here: nix-community/nixpkgs-fmt#201 (comment).

EDIT: Just realized you are the author of that issue... lol. Guess I didn't need to tell you. Force-pushed to add a note to the patch (in my haste, I forgot).

Prior to this, when used in conjunction with e.g. `format-all-mode`,
garbage like

    node: NODE_STRING@[8934; 9139), indent: IndentLevel { level: 3, alignment: 0 }

would be written to the file.
@cole-h cole-h force-pushed the cole-h:nixpkgs-fmt branch from 3142f04 to 7f6e97a Apr 29, 2020
@zimbatm
Copy link
Member

zimbatm commented Apr 29, 2020

sorry about the breaking changes. Another release is coming tomorrow with all the fixes.

@cole-h
Copy link
Member Author

cole-h commented Apr 29, 2020

All good. I'll leave this open until then (so people can stumble across it), if that works for you. Feel free to close this after the update :)

@grahamc
Copy link
Member

grahamc commented Apr 29, 2020

@ofborg eval

(testing a deploy)

@zimbatm
Copy link
Member

zimbatm commented Apr 30, 2020

we hit another issue which will probably be fixed tomorrow

@zimbatm
Copy link
Member

zimbatm commented May 2, 2020

looks like it's going to take longer

@zimbatm zimbatm merged commit 440110b into NixOS:master May 2, 2020
17 checks passed
17 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7f6e97a"; rev="7f6e97a3c8fbd53f689ca80bed8e7537b3e3bd1d"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7f6e97a"; rev="7f6e97a3c8fbd53f689ca80bed8e7537b3e3bd1d"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7f6e97a"; rev="7f6e97a3c8fbd53f689ca80bed8e7537b3e3bd1d"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7f6e97a"; rev="7f6e97a3c8fbd53f689ca80bed8e7537b3e3bd1d"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7f6e97a"; rev="7f6e97a3c8fbd53f689ca80bed8e7537b3e3bd1d"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7f6e97a"; rev="7f6e97a3c8fbd53f689ca80bed8e7537b3e3bd1d"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7f6e97a"; rev="7f6e97a3c8fbd53f689ca80bed8e7537b3e3bd1d"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
nixpkgs-fmt, nixpkgs-fmt.passthru.tests on aarch64-linux Success
Details
nixpkgs-fmt, nixpkgs-fmt.passthru.tests on x86_64-darwin Success
Details
nixpkgs-fmt, nixpkgs-fmt.passthru.tests on x86_64-linux Success
Details
@cole-h cole-h deleted the cole-h:nixpkgs-fmt branch May 2, 2020
cole-h added a commit to cole-h/nixpkgs that referenced this pull request May 3, 2020
Prior to this, when used in conjunction with e.g. `format-all-mode`,
garbage like

    node: NODE_STRING@[8934; 9139), indent: IndentLevel { level: 3, alignment: 0 }

would be written to the file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.