Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode-extensions.ms-vscode.cpptools: 0.27.0 -> 0.27.1 #86359

Merged
merged 1 commit into from May 2, 2020

Conversation

@firmero
Copy link
Contributor

firmero commented Apr 29, 2020

Motivation for this change

Previous version of package doesn't work. Complaining about missing cpptools binaries, probably cause by renaming binaries in 0.27.0 version.

Extension is now fetched from the Microsoft repository (instead of the marketplace). It also contains platform-specific binary dependencies. In the previous version they were fetched from the Microsoft website and additionally inserted to the final extension.

Package supports Linux, but there is probably a way no make it work on OSX.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Extension is now fetched from the Microsoft repository (instead of the
marketplace). It also contains platform-specific binary dependencies. In the
previous version they were fetched from the Microsoft website and additionally
inserted to the final extension.

Package supports Linux, but there is probably a way no make it work on OSX.
@eadwu
eadwu approved these changes Apr 30, 2020
Copy link
Member

eadwu left a comment

Builds fine.

Copy link
Contributor

jonringer left a comment

build fine

@jonringer jonringer merged commit 5d24a59 into NixOS:master May 2, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7e38363"; rev="7e383630ce770f657bbd0b6bca940689fffd4941"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7e38363"; rev="7e383630ce770f657bbd0b6bca940689fffd4941"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7e38363"; rev="7e383630ce770f657bbd0b6bca940689fffd4941"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7e38363"; rev="7e383630ce770f657bbd0b6bca940689fffd4941"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7e38363"; rev="7e383630ce770f657bbd0b6bca940689fffd4941"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7e38363"; rev="7e383630ce770f657bbd0b6bca940689fffd4941"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7e38363"; rev="7e383630ce770f657bbd0b6bca940689fffd4941"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@firmero firmero deleted the firmero:cpptools-0.27.1 branch May 2, 2020
@firmero firmero restored the firmero:cpptools-0.27.1 branch May 2, 2020
@firmero firmero deleted the firmero:cpptools-0.27.1 branch May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.