Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemd: 245.3 -> 245.5 #86363

Merged
merged 2 commits into from May 1, 2020
Merged

systemd: 245.3 -> 245.5 #86363

merged 2 commits into from May 1, 2020

Conversation

@flokli
Copy link
Contributor

flokli commented Apr 29, 2020

This bumps systemd to the latest stable release, 245.5.

I regenerated the patches - git am seems to be a bit more picky than patch -p1 < $file.

Changelog:

* c5e3469059 - network: fix static assertion on IPPROTO_MAX range (12 days ago) <Zbigniew Jędrzejewski-Szmek>
* a71980e030 - resolved: tone down comment in /run/systemd/{stub-,}resolve.conf (12 days ago) <Lennart Poettering>
* 7a2b5237d1 - logind: skip polkit query with --no-wall (12 days ago) <Zbigniew Jędrzejewski-Szmek>
* e7ee906371 - verify: ignore nonexistent executables if required (12 days ago) <Giedrius Statkevičius>
* 037b5e2281 - hwdb: optimize isatty()-per-line away (12 days ago) <Lennart Poettering>
* 2099a9e58d - fileio: extend comment a bit (12 days ago) <Lennart Poettering>
* abbfa8fdfa - fileio: optionally allow telling read_line_full() whether we are processing a tty or not (12 days ago) <Lennart Poettering>
* 10731dde42 - fileio: fileno() can realistically return -1 (12 days ago) <Lennart Poettering>
* 40b2a5975c - coredumpctl: support --file=PATH (12 days ago) <Frantisek Sumsal>
* 059211c7c6 - Fix pam_systemd_home's debug parameter to match man page description (12 days ago) <Joel Shapiro>
* c4883fe438 - core: make sure ProtectHostname= is handled gracefully in containers lacking seccomp (12 days ago) <Lennart Poettering>
* 3ad42f3837 - test: wait a bit after stopping the test service (13 days ago) <Frantisek Sumsal>
* 76e0d8b380 - catalog: add entry for SD_MESSAGE_UNSAFE_USER_NAME (13 days ago) <Lennart Poettering>
* ed86450ff4 - docs: hook up the new USER_NAMES document everywhere (13 days ago) <Lennart Poettering>
* 64fdacd5f1 - user-util: rework how we validate user names (13 days ago) <Lennart Poettering>
* 110d89cb65 - userdbctl: drop redundant user name validity check (13 days ago) <Lennart Poettering>
* f0300901ba - man: explicitly note that ExecSt*Post does count for After/Before ordering (13 days ago) <Luca Boccassi>
* 78b3f7348d - sleep: improve log msg slightly (13 days ago) <Lennart Poettering>
* 680d485902 - man: correct the default slice for systemd-run units (13 days ago) <Lennart Poettering>
* e04ee3c708 - hwdb: Update database of Bluetooth company identifiers (13 days ago) <Marcel Holtmann>
* d830b0574e - detect-virt: also detect "microsoft" as WSL (13 days ago) <Zbigniew Jędrzejewski-Szmek>
* dea7e0dd97 - dbus-execute: show also ProtectClock (13 days ago) <Topi Miettinen>
* 8a2b89b5d6 - man: add note that --no-hostname has limited effect (13 days ago) <Zbigniew Jędrzejewski-Szmek>
* 8b0368f511 - journal-remote: fix description of option (13 days ago) <Zbigniew Jędrzejewski-Szmek>
* da2125b6a2 - capability: don't skip ambient caps setup if we actually have something to set (13 days ago) <Lennart Poettering>
* e3b6d65c53 - shared/dissect-image: log messages from cryptsetup (13 days ago) <Topi Miettinen>
* 9c61b53c74 - resolve: reload /etc/hosts on inode change (13 days ago) <Giedrius Statkevičius>
* d540b947f4 - string-util: make sure we eat even half complete words in split() (13 days ago) <Lennart Poettering>
* 3fa7fdce59 - udev: Fix SIGSEGV in AlternativeNamesPolicy handling (13 days ago) <Lénaïc Huard>
* 2c4229221c - (tag: v245.4) man: mention that stdout logging works the same as stderr logging (4 weeks ago) <Lennart Poettering>
* 1e4711af5b - userwork: fix signal worker sends to manager requesting more workers (4 weeks ago) <Lennart Poettering>
* c7f9da1e4a - units: do not pull in home.mount from systemd-homed.service (4 weeks ago) <Lennart Poettering>
* 3469a951fa - home: fix several typos (4 weeks ago) <Vito Caputo>
* 2c5ae0f58a - homectl: fix a typo (4 weeks ago) <Piero La Terza>
* 5eedafd01a - import: Only keep RO copy if ETag header is set (4 weeks ago) <Kevin Kuehler>
* 5b434d7209 - nss-systemd: add missing jump to unlock mutex (4 weeks ago) <Zbigniew Jędrzejewski-Szmek>
* 1a2f596bcb - basic: Fix capability_ambient_set_apply for kernels < 4.3 (4 weeks ago) <Kevin Kuehler>
* e4b7c40dca - sd-journal: remove the dead code and actually fix #14695 (4 weeks ago) <Michal Sekletár>
* a0b77ea24b - user-util: switch order of checks in valid_user_group_name_or_id_full() (4 weeks ago) <Lennart Poettering>
* d71c24910d - user-util: Allow names starting with a digit (4 weeks ago) <Balint Reczey>
* 9ac3070285 - Remove stale doc about PrivateNetwork and type (4 weeks ago) <Zhu Li>
* d822e2a524 - Add `shell` to machinectl ZSH completion (4 weeks ago) <Pieter Lexis>
* 60521ea904 - Silence Wstring-plus-int warning when using clangd with GCC. (4 weeks ago) <Daan De Meyer>
* e6fcb95f4a - path-lookup: Use default value for XDG_CONFIG_DIRS if environment is not set (4 weeks ago) <David Edmundson>


Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
It seems nix is much more permissive in applying patches than git am.

These patches were regenerated by running
`git am path/to/nixpkgs/pkgs/os-specific/linux/systemd/*.patch`,
and manually running `patch -p1 < path/to/nixpkgs/pkgs/os-specific/linux/systemd/*N.patch`
where necessary.
@flokli flokli changed the title systemd: 245.4 -> 245.5 systemd: 245.3 -> 245.5 Apr 29, 2020
@flokli
Copy link
Contributor Author

flokli commented Apr 29, 2020

Also cc @GiedriusS, as this contains systemd/systemd#15207.

Also, update 0005-Add-some-NixOS-specific-unit-directories.patch to
explain how and where these paths are being used.
@flokli flokli force-pushed the flokli:systemd-245.5 branch from b53d5d7 to eb73b71 Apr 30, 2020
@flokli flokli added this to To Do in systemd via automation May 1, 2020
@FRidh FRidh added this to WIP in Staging via automation May 1, 2020
@FRidh FRidh moved this from WIP to Needs review in Staging May 1, 2020
@arianvp
arianvp approved these changes May 1, 2020
@flokli flokli merged commit b0aa80e into NixOS:staging May 1, 2020
17 checks passed
17 checks passed
systemd, systemd.passthru.tests on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="eb73b71"; rev="eb73b71df40b7bac8c2e961b217303e6e17c4355"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="eb73b71"; rev="eb73b71df40b7bac8c2e961b217303e6e17c4355"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="eb73b71"; rev="eb73b71df40b7bac8c2e961b217303e6e17c4355"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="eb73b71"; rev="eb73b71df40b7bac8c2e961b217303e6e17c4355"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="eb73b71"; rev="eb73b71df40b7bac8c2e961b217303e6e17c4355"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="eb73b71"; rev="eb73b71df40b7bac8c2e961b217303e6e17c4355"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="eb73b71"; rev="eb73b71df40b7bac8c2e961b217303e6e17c4355"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
systemd, systemd.passthru.tests on aarch64-linux Success
Details
systemd, systemd.passthru.tests on x86_64-linux Success
Details
systemd automation moved this from To Do to Done May 1, 2020
Staging automation moved this from Needs review to Done May 1, 2020
@flokli flokli deleted the flokli:systemd-245.5 branch May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
systemd
  
Done
Staging
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.