Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpio-tools: init in kernel 5.4 #86391

Merged
merged 1 commit into from May 6, 2020
Merged

gpio-tools: init in kernel 5.4 #86391

merged 1 commit into from May 6, 2020

Conversation

@kwohlfahrt
Copy link
Contributor

@kwohlfahrt kwohlfahrt commented Apr 30, 2020

Linux provides some tools to interact with the gpiochip interface (which
replaces the deprecated sysfs GPIO interface). Expose these as a
package.

Motivation for this change

In the upgrade to 20.03, the sysfs interface for GPIO pins was removed for the stock kernel. The new gpiochip interface is less straightforward to interact with, and these tools were not previously packaged.

Things done

I've tested the binaries on a raspberry pi 3.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested execution of all binary files (usually in ./result/bin/)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Mic92
Copy link
Contributor

@Mic92 Mic92 commented Apr 30, 2020

@GrahamcOfBorg build gpio-tools

@kwohlfahrt
Copy link
Contributor Author

@kwohlfahrt kwohlfahrt commented May 4, 2020

@Mic92 - is any further action needed on this?

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@Mic92
Copy link
Contributor

@Mic92 Mic92 commented May 4, 2020

Result of nixpkgs-review pr 86391 1

10 packages built:
- linuxPackages-libre.gpio-utils
- linuxPackages.gpio-utils (linuxPackages_5_4.gpio-utils ,linuxPackages_hardened.gpio-utils ,linuxPackages_xen_dom0.gpio-utils ,linuxPackages_xen_dom0_hardened.gpio-utils)
- linuxPackages_4_14.gpio-utils
- linuxPackages_4_19.gpio-utils
- linuxPackages_4_9.gpio-utils
- linuxPackages_5_5.gpio-utils
- linuxPackages_5_6.gpio-utils (linuxPackages_latest.gpio-utils ,linuxPackages_latest_hardened.gpio-utils ,linuxPackages_latest_xen_dom0.gpio-utils ,linuxPackages_latest_xen_dom0_hardened.gpio-utils)
- linuxPackages_hardkernel_4_14.gpio-utils (linuxPackages_hardkernel_latest.gpio-utils)
- linuxPackages_latest-libre.gpio-utils
- linuxPackages_testing_bcachefs.gpio-utils
@Mic92
Copy link
Contributor

@Mic92 Mic92 commented May 4, 2020

Merge conflict.

@kwohlfahrt kwohlfahrt force-pushed the kwohlfahrt:gpio-utils branch from 0e46901 to 038595e May 4, 2020
Linux provides some tools to interact with the gpiochip interface (which
replaces the deprecated sysfs GPIO interface). Expose these as a
package.

The tool has not changed much recently, so there is no need to package a
version for each kernel.
@kwohlfahrt kwohlfahrt force-pushed the kwohlfahrt:gpio-utils branch from 038595e to 89d3a60 May 4, 2020
@kwohlfahrt
Copy link
Contributor Author

@kwohlfahrt kwohlfahrt commented May 4, 2020

Fixed and squashed.

@Mic92 Mic92 merged commit ee8cde8 into NixOS:master May 6, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="89d3a60"; rev="89d3a605e31b5e4efbe1b28b08206da4e75fd689"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="89d3a60"; rev="89d3a605e31b5e4efbe1b28b08206da4e75fd689"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="89d3a60"; rev="89d3a605e31b5e4efbe1b28b08206da4e75fd689"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="89d3a60"; rev="89d3a605e31b5e4efbe1b28b08206da4e75fd689"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="89d3a60"; rev="89d3a605e31b5e4efbe1b28b08206da4e75fd689"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="89d3a60"; rev="89d3a605e31b5e4efbe1b28b08206da4e75fd689"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="89d3a60"; rev="89d3a605e31b5e4efbe1b28b08206da4e75fd689"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@kwohlfahrt kwohlfahrt deleted the kwohlfahrt:gpio-utils branch Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.