Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php.extensions: Add descriptions, homepage and license to all upstream extensions #86396

Merged
merged 1 commit into from May 1, 2020

Conversation

@etu
Copy link
Contributor

etu commented Apr 30, 2020

Motivation for this change

It makes the search result nicer since it becomes more clear which extensions comes from upstream and which doesn't. Also added the license and website and inherited the maintainers from the main package instead of just setting it to the same value.

Very much a nice to have.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
…m extensions
@Mic92
Mic92 approved these changes Apr 30, 2020
@Ma27
Ma27 approved these changes May 1, 2020
@Ma27 Ma27 merged commit 43a4f12 into NixOS:master May 1, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="56562a3"; rev="56562a30367d13e7cd71e174d71e3fa9b1cd3fff"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="56562a3"; rev="56562a30367d13e7cd71e174d71e3fa9b1cd3fff"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="56562a3"; rev="56562a30367d13e7cd71e174d71e3fa9b1cd3fff"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="56562a3"; rev="56562a30367d13e7cd71e174d71e3fa9b1cd3fff"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="56562a3"; rev="56562a30367d13e7cd71e174d71e3fa9b1cd3fff"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="56562a3"; rev="56562a30367d13e7cd71e174d71e3fa9b1cd3fff"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="56562a3"; rev="56562a30367d13e7cd71e174d71e3fa9b1cd3fff"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@etu etu deleted the etu:php-upstream-extensions-meta branch May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.