Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yabai: init at 2.4.3 #86411

Merged
merged 2 commits into from May 1, 2020
Merged

yabai: init at 2.4.3 #86411

merged 2 commits into from May 1, 2020

Conversation

@cmacrae
Copy link
Contributor

cmacrae commented Apr 30, 2020

Motivation for this change

These changes add me as a maintainer and introduce a package for yabai, for Darwin systems.
I've been maintaining my own package for quite some time, so figured it was time to finally share it.

This PR supersedes #73260

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

LnL7 left a comment

Looks like you forgot to expos this ini all-packages.nix.

@cmacrae
Copy link
Contributor Author

cmacrae commented May 1, 2020

Whoops! I did, thanks @LnL7 👍🏻 I’ll add it shortly

@cmacrae cmacrae force-pushed the cmacrae:pkgs/os-specific/darwin/yabai branch from dcfa856 to eee44bf May 1, 2020
@LnL7
Copy link
Member

LnL7 commented May 1, 2020

@GrahamcOfBorg build yabai

@LnL7
Copy link
Member

LnL7 commented May 1, 2020

Seems like it doesn't build on 10.12, is that expected?

@cmacrae
Copy link
Contributor Author

cmacrae commented May 1, 2020

Seems like it doesn't build on 10.12, is that expected?

Yep, it's not supported on 10.12, I believe. Is there any measures we can take in the package to express this? :)

@cmacrae
Copy link
Contributor Author

cmacrae commented May 1, 2020

The Makefile outlines the following build flag for clang: -mmacosx-version-min=10.13

@LnL7
Copy link
Member

LnL7 commented May 1, 2020

Just double checking.

We don't differentiate os versions, that would mean we'd have to build everything separately for each supported version. For most things we ensure builds don't use symbols that are not available on all supported versions, but frameworks are impure which means this can happen.

@LnL7
LnL7 approved these changes May 1, 2020
@LnL7 LnL7 merged commit a57cbb1 into NixOS:master May 1, 2020
19 checks passed
19 checks passed
yabai on aarch64-linux No attempt
Details
yabai on x86_64-darwin Failure
Details
yabai on x86_64-linux No attempt
Details
yabai, yabai.passthru.tests on aarch64-linux No attempt
Details
yabai, yabai.passthru.tests on x86_64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8e84599"; rev="8e8459921a4e2531abe3e86bbd3810b7e71a4735"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8e84599"; rev="8e8459921a4e2531abe3e86bbd3810b7e71a4735"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8e84599"; rev="8e8459921a4e2531abe3e86bbd3810b7e71a4735"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8e84599"; rev="8e8459921a4e2531abe3e86bbd3810b7e71a4735"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8e84599"; rev="8e8459921a4e2531abe3e86bbd3810b7e71a4735"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8e84599"; rev="8e8459921a4e2531abe3e86bbd3810b7e71a4735"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8e84599"; rev="8e8459921a4e2531abe3e86bbd3810b7e71a4735"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@cmacrae
Copy link
Contributor Author

cmacrae commented May 1, 2020

Yeah of course, that makes sense 👍
Thanks for the review and merge 🙏 Much appreciated

@cmacrae cmacrae deleted the cmacrae:pkgs/os-specific/darwin/yabai branch May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.