Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitlab: 12.8.9 -> 12.8.10 #86420

Merged
merged 3 commits into from May 1, 2020
Merged

gitlab: 12.8.9 -> 12.8.10 #86420

merged 3 commits into from May 1, 2020

Conversation

@flokli
Copy link
Contributor

flokli commented Apr 30, 2020

Motivation for this change

https://about.gitlab.com/releases/2020/04/30/security-release-12-10-2-released/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@flokli
Copy link
Contributor Author

flokli commented Apr 30, 2020

@GrahamcOfBorg test gitlab

It seems the atom feed now needs authentication. Use the /refs endpoint,
which is used for the switch branch/tag dropdown. It doesn't show all
records, but has some pagination, but works well enough for now.
@flokli flokli force-pushed the flokli:gitlab-12.8.10 branch from 188b3b6 to fc64bca Apr 30, 2020
@petabyteboy
Copy link
Member

petabyteboy commented May 1, 2020

Why does this have two commits with the same description?

@flokli
Copy link
Contributor Author

flokli commented May 1, 2020

Why does this have two commits with the same description?

It doesn't. It's Gitaly and GitLab.

@petabyteboy
Copy link
Member

petabyteboy commented May 1, 2020

Oh I see it now.

@talyz
Copy link
Contributor

talyz commented May 1, 2020

Looks good! Thanks!

@talyz talyz merged commit 998ac52 into NixOS:master May 1, 2020
17 checks passed
17 checks passed
gitaly, gitaly.passthru.tests, gitlab, gitlab.passthru.tests on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
gitaly, gitaly.passthru.tests, gitlab, gitlab.passthru.tests on aarch64-linux Success
Details
gitaly, gitaly.passthru.tests, gitlab, gitlab.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fc64bca"; rev="fc64bca95b27cf82e7c185b3a1723b326b0c20e7"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fc64bca"; rev="fc64bca95b27cf82e7c185b3a1723b326b0c20e7"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fc64bca"; rev="fc64bca95b27cf82e7c185b3a1723b326b0c20e7"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fc64bca"; rev="fc64bca95b27cf82e7c185b3a1723b326b0c20e7"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fc64bca"; rev="fc64bca95b27cf82e7c185b3a1723b326b0c20e7"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fc64bca"; rev="fc64bca95b27cf82e7c185b3a1723b326b0c20e7"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fc64bca"; rev="fc64bca95b27cf82e7c185b3a1723b326b0c20e7"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@flokli flokli deleted the flokli:gitlab-12.8.10 branch May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.