Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.owl: unbreak by reversing previous edits #86425

Merged
merged 1 commit into from May 6, 2020

Conversation

@bcdarwin
Copy link
Member

bcdarwin commented Apr 30, 2020

cc @vbgl @matthewbauer

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [NA] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
 - package was broken by 1c8aba8 (#83888)
 - fixes #85915
@bcdarwin
Copy link
Member Author

bcdarwin commented May 1, 2020

@GrahamcOfBorg build ocamlPackages.owl

1 similar comment
@vbgl
Copy link
Contributor

vbgl commented May 1, 2020

@GrahamcOfBorg build ocamlPackages.owl

@vbgl
vbgl approved these changes May 1, 2020
Copy link
Contributor

vbgl left a comment

I don’t know enough about BLAS to comment about openblasCompat, but at least, this builds and runs fine…

@vbgl vbgl merged commit d737f31 into NixOS:master May 6, 2020
19 checks passed
19 checks passed
ocamlPackages.owl on aarch64-linux No attempt
Details
ocamlPackages.phylogenetics on aarch64-linux No attempt
Details
ocamlPackages.phylogenetics on x86_64-darwin Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8f74348"; rev="8f74348be2087dca400d7a879e9330e914601764"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8f74348"; rev="8f74348be2087dca400d7a879e9330e914601764"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8f74348"; rev="8f74348be2087dca400d7a879e9330e914601764"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8f74348"; rev="8f74348be2087dca400d7a879e9330e914601764"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8f74348"; rev="8f74348be2087dca400d7a879e9330e914601764"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8f74348"; rev="8f74348be2087dca400d7a879e9330e914601764"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8f74348"; rev="8f74348be2087dca400d7a879e9330e914601764"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
ocamlPackages.owl on x86_64-darwin Success
Details
ocamlPackages.owl on x86_64-linux Success
Details
ocamlPackages.phylogenetics on x86_64-linux Success
Details
@bcdarwin bcdarwin deleted the bcdarwin:unbreak-owl branch May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.