Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jackett: 0.14.365 -> 0.16.175, add aarch64 support #86431

Merged
merged 2 commits into from May 1, 2020

Conversation

@purcell
Copy link
Contributor

purcell commented May 1, 2020

Motivation for this change

The existing jackett derivation installed the x86_64 binary on all Linux platforms, and was thus broken on aarch64, e.g. Raspberry Pi. The upstream project provides ARM64 Linux binaries: this change adds support for those, and also bumps the packaged version to the latest upstream release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
purcell added 2 commits Apr 30, 2020
The previous derivation would use the upstream x86_64 binary on ARM64,
causing binary format compatibility issues at runtime.
@purcell purcell force-pushed the purcell:jackett-aarch64 branch from 3b01e19 to c10f382 May 1, 2020
@purcell
Copy link
Contributor Author

purcell commented May 1, 2020

@GrahamcOfBorg build jackett

@offlinehacker offlinehacker merged commit 53b474b into NixOS:master May 1, 2020
18 checks passed
18 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c10f382"; rev="c10f382b097c7d1b38450c12b79850d099a21cb2"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c10f382"; rev="c10f382b097c7d1b38450c12b79850d099a21cb2"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c10f382"; rev="c10f382b097c7d1b38450c12b79850d099a21cb2"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c10f382"; rev="c10f382b097c7d1b38450c12b79850d099a21cb2"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c10f382"; rev="c10f382b097c7d1b38450c12b79850d099a21cb2"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c10f382"; rev="c10f382b097c7d1b38450c12b79850d099a21cb2"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c10f382"; rev="c10f382b097c7d1b38450c12b79850d099a21cb2"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
jackett on aarch64-linux Success
Details
jackett on x86_64-linux Success
Details
jackett, jackett.passthru.tests on aarch64-linux Success
Details
jackett, jackett.passthru.tests on x86_64-linux Success
Details
@purcell
Copy link
Contributor Author

purcell commented May 1, 2020

Thanks @offlinehacker!

@ar1a
Copy link
Contributor

ar1a commented May 11, 2020

Can #81841, #83980, and this get backported to 20.03? Jackett is too old to function, and fails on most indexers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.