Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/geoclue2: add network-online.target as wanted by geoclue2 #86437

Closed

Conversation

@matthewbauer
Copy link
Member

matthewbauer commented May 1, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@peterhoeg
Copy link
Member

peterhoeg commented May 1, 2020

Please refer to #86273

@flokli
Copy link
Contributor

flokli commented May 1, 2020

Please refer to #86273

I think @matthewbauer 's approach is correct here - see my reasoning in #86273 (comment).

@flokli
Copy link
Contributor

flokli commented May 1, 2020

@matthewbauer does geoclue2 fail on startup if network access isn't available, or is it just a service binding on a socket that will eventually try to connect to the internet to determine the location of the machine, e.g. if I press the "locate me" button in Firefox?

@peterhoeg
Copy link
Member

peterhoeg commented May 2, 2020

If geoclue fails on startup without a network, that's a bug in geoclue. I'm not saying we shouldn't work around that, but ideally we want this fixed upstream.

@matthewbauer
Copy link
Member Author

matthewbauer commented May 13, 2020

Closing in favor of #86484

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.