Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.03] backport v4l2loopback and broadcom-sta fixes #86440

Merged
merged 2 commits into from May 1, 2020

Conversation

@elohmeier
Copy link
Contributor

elohmeier commented May 1, 2020

Motivation for this change

linuxpackages_latest users in 20.03 are affected by linux 5.6 compatibility bugs fixed in the backported commits.

Things done

Backported #84736 and #84929.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer @duckfullstop @rasendubi @worldofpeace

teto and others added 2 commits Apr 8, 2020
(cherry picked from commit 8ce6508)
Reason: fixes issue for linuxPackages_latest users in 20.03, see #84736
(cherry picked from commit 9ddfde8)
Reason: fixes issue for linuxPackages_latest users in 20.03, see #84929
@mmilata
mmilata approved these changes May 1, 2020
Copy link
Member

mmilata left a comment

Confirming that v4l2loopback failed to build before and now it builds and loads fine!

Btw there's also #86209 which should work with 5.7 once it comes out.

@flokli flokli merged commit 53a1ae1 into NixOS:release-20.03 May 1, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cf9f88b"; rev="cf9f88bd9a11d9e875aa1b7dd95f37c5792c9a12"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cf9f88b"; rev="cf9f88bd9a11d9e875aa1b7dd95f37c5792c9a12"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cf9f88b"; rev="cf9f88bd9a11d9e875aa1b7dd95f37c5792c9a12"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cf9f88b"; rev="cf9f88bd9a11d9e875aa1b7dd95f37c5792c9a12"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cf9f88b"; rev="cf9f88bd9a11d9e875aa1b7dd95f37c5792c9a12"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cf9f88b"; rev="cf9f88bd9a11d9e875aa1b7dd95f37c5792c9a12"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cf9f88b"; rev="cf9f88bd9a11d9e875aa1b7dd95f37c5792c9a12"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@elohmeier elohmeier deleted the elohmeier:20.03-kmod-backports branch May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.