Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman: use $out instead of $bin with buildGoPackage #86445

Merged
merged 1 commit into from May 4, 2020

Conversation

@zowoq
Copy link
Contributor

zowoq commented May 1, 2020

This reapplies the podman changes c59c4e3#diff-25d004fa5a2ccb61035e5dd01da42798L7.

Also update the podman-wrapper which was added after #85535 was merged to staging.

cc @adisbladis @FRidh @Mic92

@adisbladis
Copy link
Member

adisbladis commented May 1, 2020

@GrahamcOfBorg test podman

@zowoq
Copy link
Contributor Author

zowoq commented May 1, 2020

https://hydra.nixos.org/jobset/nixpkgs/trunk/jobs-tab?filter=podman

Looks like the wrapper build failure is the same.

@adisbladis
Copy link
Member

adisbladis commented May 1, 2020

@GrahamcOfBorg build podman

Copy link
Member

saschagrunert left a comment

Switching to buildGoModule would solve the problem too, right? 🙃

@zowoq
Copy link
Contributor Author

zowoq commented May 4, 2020

Switching to buildGoModule would solve the problem too, right?

This would still be necessary with buildGoModule.

@Mic92 Mic92 merged commit 320f793 into NixOS:staging-next May 4, 2020
21 checks passed
21 checks passed
podman on aarch64-linux Failure
Details
podman on x86_64-darwin No attempt
Details
podman on x86_64-linux Failure
Details
podman, podman.passthru.tests on aarch64-linux Failure
Details
podman, podman.passthru.tests on x86_64-linux Failure
Details
tests.podman on aarch64-linux Timed out, unknown build status
Details
tests.podman on x86_64-linux Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b815de0"; rev="b815de00f7aa3e8c33b0792395091fdf47f8b2ec"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b815de0"; rev="b815de00f7aa3e8c33b0792395091fdf47f8b2ec"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b815de0"; rev="b815de00f7aa3e8c33b0792395091fdf47f8b2ec"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b815de0"; rev="b815de00f7aa3e8c33b0792395091fdf47f8b2ec"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b815de0"; rev="b815de00f7aa3e8c33b0792395091fdf47f8b2ec"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b815de0"; rev="b815de00f7aa3e8c33b0792395091fdf47f8b2ec"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b815de0"; rev="b815de00f7aa3e8c33b0792395091fdf47f8b2ec"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@zowoq zowoq deleted the zowoq:podman-staging branch May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.