Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.03] re2c: 1.2.1 -> 1.3 + patch #86447

Merged
merged 2 commits into from Jun 22, 2020
Merged

Conversation

@mmilata
Copy link
Member

mmilata commented May 1, 2020

Backport of #86413.


https://github.com/skvadrik/re2c/blob/1.3/CHANGELOG

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
mmilata added 2 commits Apr 30, 2020
(cherry picked from commit 2e9c802)
@drewrisinger
Copy link
Contributor

drewrisinger commented May 4, 2020

@GrahamcOfBorg build re2c

@drewrisinger
Copy link
Contributor

drewrisinger commented May 4, 2020

Ran with nixpkgs-review pr 86447 for ~30 mins, and was still just downloading the upstream dependencies. I think I'll approve this based on approval of #86413, just note for merger that it's not actually tested/built locally.

  • reviewed the diff and commit messages
  • made sure ofBorg build succeeded for all applicable platforms
  • run nix-review for a reasonable amount of time without any failures (or marked preexisting failures as broken). Ran for 30 mins, but didn't actually get to build anything in that time.
Copy link
Contributor

drewrisinger left a comment

Approved based on prior approval of #86413. Build attempted locally but took too long to produce a meaningful result. OfBorg build works though.

@nixos-discourse
Copy link

nixos-discourse commented May 4, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/148

@vcunat
vcunat approved these changes Jun 22, 2020
Copy link
Member

vcunat left a comment

Sounds OK. This has somehow fallen through the cracks.

@vcunat vcunat added this to Ready in Staging (stable) via automation Jun 22, 2020
@vcunat vcunat merged commit acaa673 into NixOS:staging-20.03 Jun 22, 2020
18 checks passed
18 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9c14030"; rev="9c14030f8a540a1305cc101a6dc2ef1f7368cadc"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9c14030"; rev="9c14030f8a540a1305cc101a6dc2ef1f7368cadc"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9c14030"; rev="9c14030f8a540a1305cc101a6dc2ef1f7368cadc"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9c14030"; rev="9c14030f8a540a1305cc101a6dc2ef1f7368cadc"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9c14030"; rev="9c14030f8a540a1305cc101a6dc2ef1f7368cadc"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9c14030"; rev="9c14030f8a540a1305cc101a6dc2ef1f7368cadc"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9c14030"; rev="9c14030f8a540a1305cc101a6dc2ef1f7368cadc"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
re2c on aarch64-linux Success
Details
re2c on x86_64-linux Success
Details
re2c, re2c.passthru.tests on aarch64-linux Success
Details
re2c, re2c.passthru.tests on x86_64-linux Success
Details
Staging (stable) automation moved this from Ready to Done Jun 22, 2020
@mmilata mmilata deleted the mmilata:20.03/re2c-1.3 branch Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.