Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.03] cups: 2.3.1 -> 2.3.3 #86455

Merged
merged 1 commit into from May 9, 2020
Merged

Conversation

@mmilata
Copy link
Member

mmilata commented May 1, 2020

Backport of #86419.


Changes: https://github.com/apple/cups/releases/tag/v2.3.3

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@drewrisinger
Copy link
Contributor

drewrisinger commented May 4, 2020

@GrahamcOfBorg build cups

Copy link
Contributor

drewrisinger left a comment

  • reviewed the diff and commit messages
  • made sure ofBorg build succeeded for all applicable platforms. Don't know how to trigger for Darwin, but that part was unchanged.
  • run nix-review for a reasonable amount of time without any failures (or marked preexisting failures as broken). Run for ~60 mins, and didn't finish downloading all the dependencies...
@drewrisinger
Copy link
Contributor

drewrisinger commented May 4, 2020

@GrahamcOfBorg build cups

@nixos-discourse
Copy link

nixos-discourse commented May 4, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/148

@FRidh FRidh changed the base branch from staging-20.03 to release-20.03 May 9, 2020
@FRidh FRidh merged commit f354d93 into NixOS:release-20.03 May 9, 2020
17 of 18 checks passed
17 of 18 checks passed
grahamcofborg-eval Checking original out paths
Details
Evaluation Performance Report Evaluator Performance Report
Details
cups on aarch64-linux Success
Details
cups on x86_64-linux Success
Details
cups, cups.passthru.tests on aarch64-linux Success
Details
cups, cups.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d680241"; rev="d680241ebe64a3e30778525b307bda7a4f2f0674"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d680241"; rev="d680241ebe64a3e30778525b307bda7a4f2f0674"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d680241"; rev="d680241ebe64a3e30778525b307bda7a4f2f0674"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d680241"; rev="d680241ebe64a3e30778525b307bda7a4f2f0674"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d680241"; rev="d680241ebe64a3e30778525b307bda7a4f2f0674"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d680241"; rev="d680241ebe64a3e30778525b307bda7a4f2f0674"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d680241"; rev="d680241ebe64a3e30778525b307bda7a4f2f0674"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@mmilata mmilata deleted the mmilata:20.03/cups-2.3.3 branch May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.