Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kops: fix hash #86457

Merged
merged 1 commit into from May 1, 2020
Merged

kops: fix hash #86457

merged 1 commit into from May 1, 2020

Conversation

@flokli
Copy link
Contributor

flokli commented May 1, 2020

As seen on https://hydra.nixos.org/build/118009308

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@flokli flokli requested review from zimbatm, Mic92 and kampka May 1, 2020
@ofborg ofborg bot requested a review from offlinehacker May 1, 2020
@@ -58,6 +58,6 @@ in rec {

kops_1_16 = mkKops {
version = "1.16.1";
sha256 = "08vy57ln0qar961sf9vbrh29f04qj5siqsfim1kqwvj5xrvwa39i";
sha256 = "04ji1703z6b3rd4wmccah68api0jj2bndzkgdzqi855gccqbmi5g";

This comment has been minimized.

Copy link
@Mic92

Mic92 May 1, 2020

Contributor

I am confused. Ofborg disagrees:

  wanted: sha256:04ji1703z6b3rd4wmccah68api0jj2bndzkgdzqi855gccqbmi5g
  got:    sha256:08vy57ln0qar961sf9vbrh29f04qj5siqsfim1kqwvj5xrvwa39i

This comment has been minimized.

Copy link
@Mic92

Mic92 May 1, 2020

Contributor

It builds locally though?

This comment has been minimized.

Copy link
@flokli

flokli May 1, 2020

Author Contributor

I did locally replace with all-zeros and TOFU-copied in the hash I got, and successfully built.

Seems this is also what hydra sees, so I'd assume ofborg is wrong here.

Can you checkout locally too?

This comment has been minimized.

Copy link
@Mic92

Mic92 May 1, 2020

Contributor

It built locally as I said.

@flokli flokli merged commit a075ecd into NixOS:master May 1, 2020
17 checks passed
17 checks passed
kops, kops.passthru.tests on aarch64-linux Unexpected error: command failed with exit code 102
Details
kops, kops.passthru.tests on x86_64-linux Unexpected error: command failed with exit code 102
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4d7bd77"; rev="4d7bd77f75b8afcae16b6f5efb0060e004f3b936"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4d7bd77"; rev="4d7bd77f75b8afcae16b6f5efb0060e004f3b936"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4d7bd77"; rev="4d7bd77f75b8afcae16b6f5efb0060e004f3b936"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4d7bd77"; rev="4d7bd77f75b8afcae16b6f5efb0060e004f3b936"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4d7bd77"; rev="4d7bd77f75b8afcae16b6f5efb0060e004f3b936"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4d7bd77"; rev="4d7bd77f75b8afcae16b6f5efb0060e004f3b936"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4d7bd77"; rev="4d7bd77f75b8afcae16b6f5efb0060e004f3b936"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
kops, kops.passthru.tests on x86_64-darwin Success
Details
@flokli flokli deleted the flokli:kops-1.16.1 branch May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.