Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

radare2: 4.3.1 -> 4.4.0 #86458

Merged
merged 3 commits into from May 1, 2020
Merged

radare2: 4.3.1 -> 4.4.0 #86458

merged 3 commits into from May 1, 2020

Conversation

@Mic92
Copy link
Contributor

Mic92 commented May 1, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Mic92 Mic92 requested a review from dtzWill May 1, 2020
@Mic92 Mic92 mentioned this pull request May 1, 2020
@ofborg ofborg bot requested review from 7c6f434c and makefu May 1, 2020
@Mic92 Mic92 marked this pull request as draft May 1, 2020
@Mic92
Copy link
Contributor Author

Mic92 commented May 1, 2020

Looks like this breaks all appimage applications?

@Mic92 Mic92 marked this pull request as ready for review May 1, 2020
@Mic92 Mic92 force-pushed the Mic92:radare2 branch 2 times, most recently from a228c93 to 695e2aa May 1, 2020
Fix future breakages by mirroring the source
@Mic92 Mic92 force-pushed the Mic92:radare2 branch from 695e2aa to 5569860 May 1, 2020
@Mic92
Copy link
Contributor Author

Mic92 commented May 1, 2020

Result of nixpkgs-review pr 86458 1

24 packages built:
- Sylk
- appimage-run
- deltachat-electron
- irccloud
- jitsi-meet-electron
- joplin-desktop
- ledger-live-desktop
- marktext
- minetime
- notable
- python27Packages.r2pipe
- python37Packages.r2pipe
- python38Packages.r2pipe
- radare2
- ripcord
- runwayml
- soulseekqt
- ssb-patchwork
- standardnotes
- station
- tusk
- unityhub
- wootility
- zulip
@Mic92 Mic92 merged commit e4fadff into NixOS:master May 1, 2020
17 checks passed
17 checks passed
radare2, radare2.passthru.tests, unityhub, unityhub.passthru.tests on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5569860"; rev="5569860b1fe5c13be80febeb98a14d2f73884fe5"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5569860"; rev="5569860b1fe5c13be80febeb98a14d2f73884fe5"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5569860"; rev="5569860b1fe5c13be80febeb98a14d2f73884fe5"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5569860"; rev="5569860b1fe5c13be80febeb98a14d2f73884fe5"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5569860"; rev="5569860b1fe5c13be80febeb98a14d2f73884fe5"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5569860"; rev="5569860b1fe5c13be80febeb98a14d2f73884fe5"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5569860"; rev="5569860b1fe5c13be80febeb98a14d2f73884fe5"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
radare2, radare2.passthru.tests, unityhub, unityhub.passthru.tests on aarch64-linux Success
Details
radare2, radare2.passthru.tests, unityhub, unityhub.passthru.tests on x86_64-linux Success
Details
@Mic92 Mic92 deleted the Mic92:radare2 branch May 1, 2020
@makefu
Copy link
Contributor

makefu commented May 1, 2020

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.