Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terminator: 1.91 -> 1.92 #86462

Merged
merged 1 commit into from May 1, 2020
Merged

terminator: 1.91 -> 1.92 #86462

merged 1 commit into from May 1, 2020

Conversation

@SFrijters
Copy link
Member

SFrijters commented May 1, 2020

Motivation for this change

The terminator project has been picked up by a new team and they have started to release new versions. This latest version also makes terminator compatible with python3.

Attempts to close #86415 .

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Open issue: I have to strip out a check for dbus-python to allow installation to proceed. If I look at the patched/wrapped result dbus-python is correctly added, so for me it didn't seem to cause any problems. A similar thing seems to have been done in 3a1033c .

@bjornfor bjornfor merged commit 8855c3a into NixOS:master May 1, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2a42030"; rev="2a42030e55acf6f5e2be002b6bbb7c99c2834f61"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2a42030"; rev="2a42030e55acf6f5e2be002b6bbb7c99c2834f61"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2a42030"; rev="2a42030e55acf6f5e2be002b6bbb7c99c2834f61"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2a42030"; rev="2a42030e55acf6f5e2be002b6bbb7c99c2834f61"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2a42030"; rev="2a42030e55acf6f5e2be002b6bbb7c99c2834f61"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2a42030"; rev="2a42030e55acf6f5e2be002b6bbb7c99c2834f61"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2a42030"; rev="2a42030e55acf6f5e2be002b6bbb7c99c2834f61"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
terminator, terminator.passthru.tests on aarch64-linux Success
Details
terminator, terminator.passthru.tests on x86_64-linux Success
Details
src = fetchFromGitHub {
owner = "gnome-terminator";
repo = "terminator";
rev = "bb24273eb40dc5eac97de74064488701fa40a743";

This comment has been minimized.

Copy link
@jtojnar

jtojnar May 1, 2020

Contributor
Suggested change
rev = "bb24273eb40dc5eac97de74064488701fa40a743";
rev = "v${version}";

This comment has been minimized.

Copy link
@SFrijters

SFrijters May 1, 2020

Author Member

Good point! The PR was already merged though - should I open a new one for the fixup, or reopen this one?

This comment has been minimized.

Copy link
@jtojnar

jtojnar May 1, 2020

Contributor

Ugh, missed this was merged. Since merged PRs cannot be reopened, I pushed the fixes in 64c09a3.

This comment has been minimized.

Copy link
@bjornfor

bjornfor May 1, 2020

Contributor

@jtojnar : Thanks!

@SFrijters SFrijters mentioned this pull request May 1, 2020
0 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.