Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p7zip: fix two CVEs #86468

Merged
merged 1 commit into from May 1, 2020
Merged

p7zip: fix two CVEs #86468

merged 1 commit into from May 1, 2020

Conversation

@tokudan
Copy link
Contributor

tokudan commented May 1, 2020

Motivation for this change

This is a backport of #86417 to the current release. I've excluded the warning about the software effectively having no developer, to avoid breaking existing setups, as there are no more publicly known vulnerabilities at this point.
Not sure what our release managers prefer (@worldofpeace @disassembler) regarding the warning?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
(cherry picked from commit dd16c39)
@mweinelt
Copy link
Member

mweinelt commented May 1, 2020

Built with nixpkgs-review, LGTM.

1 package failed to build:

flashtool
builder for '/nix/store/sygvfdclh3hgi51ayv2lrsinj87ywpng-flashtool-0.9.14.0-linux.tar.7z.drv' failed with exit code 1; last 10 log lines:
  ***
  Unfortunately, we cannot download file flashtool-0.9.14.0-linux.tar.7z automatically.
  Please go to http://dfiles.eu/files/n8c1c3pgc to download it yourself, and add it to the Nix store
  using either
    nix-store --add-fixed sha256 flashtool-0.9.14.0-linux.tar.7z
  or
    nix-prefetch-url --type sha256 file:///path/to/flashtool-0.9.14.0-linux.tar.7z

cannot build derivation '/nix/store/asngzqlmvsni74z9ms0bcbbv8asqask4-flashtool-0.9.14.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/n4gqsih58rhk4i0kc982vl3025vbf1sh-env.drv': 1 dependencies couldn't be built

14 packages built:

  • ark
  • dtrx
  • far2l
  • fuse-7z-ng
  • higan
  • hostsblock
  • jetbrains.clion
  • jetbrains.datagrip
  • jetbrains.goland
  • jetbrains.idea-community
  • jetbrains.idea-ultimate
  • kcc
  • sweethome3d.furniture-editor
  • win-signed-gplpv-drivers
@andir andir merged commit cff5440 into NixOS:release-20.03 May 1, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="de316f9"; rev="de316f97d7bcf3117ec8983090f1b7a44abaab45"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="de316f9"; rev="de316f97d7bcf3117ec8983090f1b7a44abaab45"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="de316f9"; rev="de316f97d7bcf3117ec8983090f1b7a44abaab45"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="de316f9"; rev="de316f97d7bcf3117ec8983090f1b7a44abaab45"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="de316f9"; rev="de316f97d7bcf3117ec8983090f1b7a44abaab45"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="de316f9"; rev="de316f97d7bcf3117ec8983090f1b7a44abaab45"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="de316f9"; rev="de316f97d7bcf3117ec8983090f1b7a44abaab45"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
p7zip, p7zip.passthru.tests on aarch64-linux Success
Details
p7zip, p7zip.passthru.tests on x86_64-linux Success
Details
@andir
Copy link
Member

andir commented May 1, 2020

I think this is the correct way forward for a release. If we receive notice of enough unfixed/unfixable issues we might consider marking it as insecure but for now just fixing those we know about seems reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.