Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/tests: add systemd-networkd-ipv6-prefix-delegation #86471

Merged
merged 2 commits into from May 1, 2020

Conversation

@andir
Copy link
Member

andir commented May 1, 2020

Motivation for this change

This is a follow-up to the PR #82026 that contains the promised tests.

In this test I am testing if we can properly propagate prefixes received
via DHCPv6 PD with the networkd options in our module system.

The comments in the test should be sufficient to follow the idea and
what is going on.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@andir
Copy link
Member Author

andir commented May 1, 2020

@GrahamcOfBorg test systemd-networkd-ipv6-prefix-delegation

@ofborg ofborg bot added the 6.topic: nixos label May 1, 2020
@andir
Copy link
Member Author

andir commented May 1, 2020

I would very much like to add this to the tests required for a channel bump. Any objections?

Motivation: I actually have my home router setup like this and it would be a bummer if that breaks ;)

@andir andir force-pushed the andir:systemd-networkd-prefix-delegation-test branch 3 times, most recently from d54c9f9 to 5337487 May 1, 2020
@andir andir changed the title nixos/tests/: add systemd-networkd-ipv6-prefix-delegation nixos/tests: add systemd-networkd-ipv6-prefix-delegation May 1, 2020
@mweinelt
Copy link
Member

mweinelt commented May 1, 2020

Looks very well done, loving the documentation bits. Runs perfectly well!

@andir andir force-pushed the andir:systemd-networkd-prefix-delegation-test branch from 5337487 to 28f08ce May 1, 2020
Copy link
Contributor

flokli left a comment

This is really nice, thank you :-)

I added some comments.

@andir andir force-pushed the andir:systemd-networkd-prefix-delegation-test branch 2 times, most recently from fd4bec2 to 3aeab64 May 1, 2020
This is a follow-up to the PR #82026 that contains the promised tests.

In this test I am testing if we can properly propagate prefixes received
via DHCPv6 PD with the networkd options in our module system.

The comments in the test should be sufficient to follow the idea and
what is going on.
@andir andir force-pushed the andir:systemd-networkd-prefix-delegation-test branch from 3aeab64 to 47529bc May 1, 2020
@flokli
Copy link
Contributor

flokli commented May 1, 2020

👍 on adding this to the tested jobset.

@flokli flokli merged commit 4a2f821 into NixOS:master May 1, 2020
7 of 9 checks passed
7 of 9 checks passed
grahamcofborg-eval Beginning Evaluations
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6ec01c7"; rev="6ec01c7dac726ca46fe180aa50f00dc0d3a8ccb2"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6ec01c7"; rev="6ec01c7dac726ca46fe180aa50f00dc0d3a8ccb2"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6ec01c7"; rev="6ec01c7dac726ca46fe180aa50f00dc0d3a8ccb2"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6ec01c7"; rev="6ec01c7dac726ca46fe180aa50f00dc0d3a8ccb2"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6ec01c7"; rev="6ec01c7dac726ca46fe180aa50f00dc0d3a8ccb2"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.