Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/steam: init #86480

Merged
merged 3 commits into from Jul 30, 2020
Merged

nixos/steam: init #86480

merged 3 commits into from Jul 30, 2020

Conversation

@mkg20001
Copy link
Member

@mkg20001 mkg20001 commented May 1, 2020

Motivation for this change

It would be great if steam would "just work"

This module achives that by enabling common options needed to make steam just work, that aren't enabled by default

See #47932

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
nixos/modules/programs/steam.nix Outdated Show resolved Hide resolved
@mkg20001 mkg20001 force-pushed the mkg20001:steam-module branch from a400a27 to e8f2f57 May 2, 2020
@aanderse
Copy link
Contributor

@aanderse aanderse commented May 5, 2020

Do we want/need this? #45492 (comment)

@xfix
Copy link
Contributor

@xfix xfix commented May 6, 2020

I don't think #45492 (comment) is necessary. If the issue still occurs, it's likely very limited, and won't occur in most cases, and I don't think enabling Steam should be doing system-wide changes unless it's necessary without making it clear they occur.

Keep in mind in Ubuntu, the number of open file handles is 1024, matching NixOS's value. Therefore, if having such a file handle limit causes issues, it will also cause them on Ubuntu.

@Atemu
Copy link
Member

@Atemu Atemu commented May 6, 2020

Two people just commented that it works fine on their machine and the maximum fds per process are 524288 on my machine now, not the 4096 OP had back then.

@mkg20001
Copy link
Member Author

@mkg20001 mkg20001 commented May 6, 2020

I'm not sure if some values are dynamic in the kernel based on the available RAM, so people with lower ram might hit the issue while ones with higher wouldn't
Or some defaults might have changed in nixOS/upstream

@aanderse
Copy link
Contributor

@aanderse aanderse commented May 6, 2020

Awesome, thanks!

@xfix
xfix approved these changes May 6, 2020
@mkg20001 mkg20001 force-pushed the mkg20001:steam-module branch from e8f2f57 to 6d876af May 7, 2020
@xfix
xfix approved these changes May 7, 2020
@NickHu
NickHu approved these changes May 24, 2020
Copy link
Contributor

@NickHu NickHu left a comment

Looks good to me and should allow me to simplify some of my configs, which is much appreciated :)

@mkg20001 mkg20001 force-pushed the mkg20001:steam-module branch 2 times, most recently from d4e08f8 to 570a142 Jul 5, 2020
@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Jul 7, 2020

@mkg20001 This looks good, but we need to update documentation.

@mkg20001 mkg20001 force-pushed the mkg20001:steam-module branch 2 times, most recently from f7abf58 to cdf8219 Jul 12, 2020
@worldofpeace worldofpeace changed the title modules.steam: init module with workarrounds nixos/steam: init Jul 12, 2020
@mkg20001 mkg20001 force-pushed the mkg20001:steam-module branch from e7e4602 to cd35c59 Jul 12, 2020
@mkg20001 mkg20001 force-pushed the mkg20001:steam-module branch 2 times, most recently from fda1f66 to 53c51ea Jul 12, 2020
@ofborg ofborg bot added the 8.has: changelog label Jul 12, 2020
@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Jul 14, 2020

Wah conflicts. Anyways, with #86480 (comment) I preapprove of this.

mkg20001 added 3 commits May 1, 2020
@mkg20001 mkg20001 force-pushed the mkg20001:steam-module branch from 53c51ea to 2d63269 Jul 30, 2020
@worldofpeace worldofpeace merged commit 08bc533 into NixOS:master Jul 30, 2020
15 checks passed
15 checks passed
tests
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2d63269"; rev="2d63269e0d2d44d0ac3ddc14c40c88686f8b2cfa"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2d63269"; rev="2d63269e0d2d44d0ac3ddc14c40c88686f8b2cfa"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2d63269"; rev="2d63269e0d2d44d0ac3ddc14c40c88686f8b2cfa"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2d63269"; rev="2d63269e0d2d44d0ac3ddc14c40c88686f8b2cfa"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2d63269"; rev="2d63269e0d2d44d0ac3ddc14c40c88686f8b2cfa"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2d63269"; rev="2d63269e0d2d44d0ac3ddc14c40c88686f8b2cfa"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2d63269"; rev="2d63269e0d2d44d0ac3ddc14c40c88686f8b2cfa"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@adamlwgriffiths
Copy link

@adamlwgriffiths adamlwgriffiths commented Sep 22, 2020

I'm not sure if steam module and wiki page have diverged slightly.
The wiki page has the following example at the top:
image

The specific difference is the following line:
hardware.opengl.extraPackages32 = with pkgs.pkgsi686Linux; [ libva ];

This isn't present in the current steam module.

I'm not sure if this is a deviation, or if it just happens to be part of a larger "example" nix file and isn't actually relevant to running steam.

If the former, this should be made consistent.
If the latter, it should be removed as it is confusing.

@mkg20001
Copy link
Member Author

@mkg20001 mkg20001 commented Sep 23, 2020

I'm not quite sure either, but it refers to 32bit libraries there so a game might need it available, tho that is weird since usually everything is provided by the steam runtime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

9 participants
You can’t perform that action at this time.