Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.03] libvorbis: fix 404'ing patch #86485

Merged
merged 1 commit into from May 2, 2020
Merged

Conversation

@cole-h
Copy link
Member

cole-h commented May 1, 2020

Also use full commit for the other patch, just in case there's ever a
collision, as unlikely as that may be.

(cherry picked from commit f02e1c2)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @veprbl -- Should 19.03 go to staging-19.03 or release-19.03, considering it's EOL? And should 19.09 go to release-19.09, or staging-19.09?

Also use full commit for the other patch, just in case there's ever a
collision, as unlikely as that may be.

(cherry picked from commit f02e1c2)
@ehmry
ehmry approved these changes May 1, 2020
@veprbl veprbl added this to Ready in Staging (stable) May 1, 2020
@veprbl
Copy link
Member

veprbl commented May 1, 2020

cc @veprbl -- Should 19.03 go to staging-19.03 or release-19.03, considering it's EOL? And should 19.09 go to release-19.09, or staging-19.09?

Sorry for not answering this question earlier. My understanding is that there is not much point in applying changes that cause rebuilds to those older branches. That requires extra work that is usually done by other community members. That includes actually testing these backports or making sure that the channels are not blocked or managing the staging workflow.

@cole-h
Copy link
Member Author

cole-h commented May 1, 2020

So, correct me if I'm wrong, this is the only necessary backport?

@veprbl
Copy link
Member

veprbl commented May 1, 2020

Yes, we want all the fixes to be backported to the current stable release. There aren't such expectations about the EOL releases.

@adisbladis adisbladis merged commit 354beb8 into NixOS:staging-20.03 May 2, 2020
17 checks passed
17 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="62216c7"; rev="62216c7f8ea9ddb87f0951dead06ba1ad8c7b750"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="62216c7"; rev="62216c7f8ea9ddb87f0951dead06ba1ad8c7b750"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="62216c7"; rev="62216c7f8ea9ddb87f0951dead06ba1ad8c7b750"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="62216c7"; rev="62216c7f8ea9ddb87f0951dead06ba1ad8c7b750"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="62216c7"; rev="62216c7f8ea9ddb87f0951dead06ba1ad8c7b750"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="62216c7"; rev="62216c7f8ea9ddb87f0951dead06ba1ad8c7b750"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="62216c7"; rev="62216c7f8ea9ddb87f0951dead06ba1ad8c7b750"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
libvorbis, libvorbis.passthru.tests on aarch64-linux Success
Details
libvorbis, libvorbis.passthru.tests on x86_64-darwin Success
Details
libvorbis, libvorbis.passthru.tests on x86_64-linux Success
Details
Staging (stable) automation moved this from Ready to Done May 2, 2020
@cole-h cole-h deleted the cole-h:staging-20.03 branch May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.