Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.03] emacs: improve setup hook #86491

Closed
wants to merge 1 commit into from

Conversation

@Xe
Copy link
Contributor

Xe commented May 1, 2020

Motivation for this change

Backports #78680 to 20.03

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
- Add packages installed in a sub-directory of site-lisp, such as
  mu4e, to EMACSLOADPATH.

- Add ELPA packages to EMACSLOADPATH.

- Add each package only once to EMACSLOADPATH. Before, each package
  would typically be added twice for each transitive dependency
  leading to a huge variable for a package having many dependencies.

Fixed #78680

(cherry picked from commit 2d2de74)
@rycee
Copy link
Member

rycee commented May 1, 2020

Seems like a duplicate of #86344?

@Xe
Copy link
Contributor Author

Xe commented May 1, 2020

The current version in master causes EMACSLOADPATH variables like this: https://gist.github.com/Xe/5ab74c47227174908b50f6c60502e9e4#file-sh-cfg-L23

This patch seems to prevent that from happening for whatever reason.

@rycee
Copy link
Member

rycee commented May 1, 2020

I'm confused, have you found a problem with EMACSLOADPATH in master? I tried to fix the problem with duplicate entries in EMACSLOADPATH and what I came up with has been in master for a while and in release-20.03 since #86344 got merged.

@Xe
Copy link
Contributor Author

Xe commented May 1, 2020

erm, sorry, the current version in release-20.03 is what causes the quadratic amount of stuff in EMACSLOADPATH.

@rycee
Copy link
Member

rycee commented May 1, 2020

Ah, OK. Then I think this PR can be closed, the two commits that are fixing the EMACSLOADPATH problem are already in the release-20.03 branch and should be available in the next successful channel build.

Indeed, this PR only includes one of the necessary patches and if you look at the changes you'll notice that it is actually undoing the necessary d3eeaec commit 😀

@Xe Xe closed this May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.