Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php.extensions.rdkafka: init at 4.0.3 #86492

Merged
merged 1 commit into from May 16, 2020
Merged

Conversation

@etu
Copy link
Contributor

etu commented May 1, 2020

Motivation for this change

Added by request from @alebon. This fixes #86463

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@etu etu force-pushed the etu:php-extension-init-rdkafka branch from 6d33861 to 5df9d34 May 1, 2020
@etu etu changed the title php.extensions.rdkafka: init at 3.0.3 php.extensions.rdkafka: init at 4.0.3 May 1, 2020
@ofborg ofborg bot requested review from globin, talyz, Ma27 and aanderse May 1, 2020
@etu etu force-pushed the etu:php-extension-init-rdkafka branch from 5df9d34 to a13be9f May 1, 2020
@etu
Copy link
Contributor Author

etu commented May 1, 2020

@ofborg build php74.extensions.rdkafka php73.extensions.rdkafka php72.extensions.rdkafka


postPhpize = ''
substituteInPlace configure \
--replace 'SEARCH_PATH="/usr/local /usr"' 'SEARCH_PATH=${pkgs.rdkafka}'

This comment has been minimized.

Copy link
@aanderse

aanderse May 1, 2020

Contributor

Maybe a regex that looks for a line starting with SEARCH_PATH would be more robust.

This comment has been minimized.

Copy link
@etu

etu May 1, 2020

Author Contributor

It's also more complex to read, they have had the same SEARCH_PATH as a result from 3.0.3 to 4.0.3, so it doesn't seem to change that much.

Also, if it would fail to build. It's easy to spot that during the package update.

@etu etu force-pushed the etu:php-extension-init-rdkafka branch from a13be9f to e683f5c May 16, 2020
@etu
Copy link
Contributor Author

etu commented May 16, 2020

@ofborg build php.extensions.rdkafka

@ofborg ofborg bot requested a review from aanderse May 16, 2020
@talyz
talyz approved these changes May 16, 2020
Copy link
Contributor

talyz left a comment

Builds and loads fine and @alebon confirmed that it worked for them.

@talyz talyz merged commit 37f9045 into NixOS:master May 16, 2020
17 checks passed
17 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e683f5c"; rev="e683f5cbfa0e96da29514c8329217e2880a80a26"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e683f5c"; rev="e683f5cbfa0e96da29514c8329217e2880a80a26"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e683f5c"; rev="e683f5cbfa0e96da29514c8329217e2880a80a26"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e683f5c"; rev="e683f5cbfa0e96da29514c8329217e2880a80a26"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e683f5c"; rev="e683f5cbfa0e96da29514c8329217e2880a80a26"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e683f5c"; rev="e683f5cbfa0e96da29514c8329217e2880a80a26"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e683f5c"; rev="e683f5cbfa0e96da29514c8329217e2880a80a26"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
php.extensions.rdkafka on aarch64-linux Success
Details
php.extensions.rdkafka on x86_64-darwin Success
Details
php.extensions.rdkafka on x86_64-linux Success
Details
@etu etu deleted the etu:php-extension-init-rdkafka branch May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.