Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

woeusb,jetbrains,ark: prune p7zip #86497

Merged
merged 3 commits into from May 2, 2020
Merged

Conversation

@eadwu
Copy link
Member

eadwu commented May 1, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
eadwu added 3 commits May 1, 2020
@eadwu eadwu requested review from edwtjo and ttuegel as code owners May 1, 2020
@eadwu
Copy link
Member Author

eadwu commented May 1, 2020

woeusb -> patch using 7z is broken now, though there's a warning about that [1]
jetbrains -> didn't find anything using 7z during the build
ark -> pretty sure it'll search the $PATH anyway

[1] https://github.com/slacka/WoeUSB/blob/f21bb19e6aa575682b84c4e909e6509b04aa58e2/src/woeusb#L1571

@nixos-discourse
Copy link

nixos-discourse commented May 1, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/p7zip-and-possible-rces/6951/6

@petabyteboy
Copy link
Contributor

petabyteboy commented May 2, 2020

Built all three and tested functionality of ark and jetbrains 👍

@petabyteboy petabyteboy merged commit 06fa14f into NixOS:master May 2, 2020
15 of 16 checks passed
15 of 16 checks passed
ark, ark.passthru.tests, woeusb, woeusb.passthru.tests on aarch64-linux
Details
Evaluation Performance Report Evaluator Performance Report
Details
ark, ark.passthru.tests, woeusb, woeusb.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="142d288"; rev="142d288e2c8f8cbbc7121da220470c78fce1bd67"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="142d288"; rev="142d288e2c8f8cbbc7121da220470c78fce1bd67"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="142d288"; rev="142d288e2c8f8cbbc7121da220470c78fce1bd67"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="142d288"; rev="142d288e2c8f8cbbc7121da220470c78fce1bd67"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="142d288"; rev="142d288e2c8f8cbbc7121da220470c78fce1bd67"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="142d288"; rev="142d288e2c8f8cbbc7121da220470c78fce1bd67"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="142d288"; rev="142d288e2c8f8cbbc7121da220470c78fce1bd67"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.