Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

genpass: init at 0.4.1 #86504

Merged
merged 2 commits into from May 9, 2020
Merged

genpass: init at 0.4.1 #86504

merged 2 commits into from May 9, 2020

Conversation

@cyplo
Copy link
Contributor

cyplo commented May 1, 2020

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
pkgs/tools/security/genpass/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/genpass/default.nix Outdated Show resolved Hide resolved
maintainers/maintainer-list.nix Outdated Show resolved Hide resolved
@cyplo cyplo force-pushed the cyplo:add-genpass branch from 26459ee to e9c20ea May 2, 2020
@cyplo
Copy link
Contributor Author

cyplo commented May 2, 2020

thanks so much for a comprehensive review @cole-h !
all should be changed now - if you could take a look ? :)

@cyplo cyplo force-pushed the cyplo:add-genpass branch from e9c20ea to bd2928a May 2, 2020
@cole-h
cole-h approved these changes May 2, 2020
Copy link
Member

cole-h left a comment

Diff LGTM. Binary displays help and does indeed generate passwords/phrases.

[1 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/86504
1 package built:
genpass
@cyplo
Copy link
Contributor Author

cyplo commented May 7, 2020

heya @cole-h - would you know who best to ping here to get this one merged ? thanks ! :)

@nixos-discourse
Copy link

nixos-discourse commented May 7, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/150

@bjornfor bjornfor merged commit 69c6d18 into NixOS:master May 9, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
genpass, genpass.passthru.tests on aarch64-linux Success
Details
genpass, genpass.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bd2928a"; rev="bd2928af83fb3233358673a1a3b56095c2326150"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bd2928a"; rev="bd2928af83fb3233358673a1a3b56095c2326150"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bd2928a"; rev="bd2928af83fb3233358673a1a3b56095c2326150"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bd2928a"; rev="bd2928af83fb3233358673a1a3b56095c2326150"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bd2928a"; rev="bd2928af83fb3233358673a1a3b56095c2326150"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bd2928a"; rev="bd2928af83fb3233358673a1a3b56095c2326150"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bd2928a"; rev="bd2928af83fb3233358673a1a3b56095c2326150"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@cyplo cyplo deleted the cyplo:add-genpass branch May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.