Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binutils: backport fix for 'invalid string offset' on arm #86525

Closed
wants to merge 1 commit into from

Conversation

@thefloweringash
Copy link
Member

thefloweringash commented May 2, 2020

Fixes errors during linking:

/nix/store/{hash}-binutils-2.31.1/bin/ld: /nix/store/{hash}-glu-9.0.1/lib/libGLU.so: invalid string offset 1353 >= 1011 for section `.strtab'
Motivation for this change

This error shows up seemingly randomly when reading armv7 .so files with libbfd. In my case it prevents me building kinfocenter due to ld failing to read libGLU.so.

This will be obsolete when binutils is upgraded (eg, #78197 or #85951), however it seems there's a lingering issue with lchmod that's making this difficult.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Fixes errors during linking:

/nix/store/{hash}-binutils-2.31.1/bin/ld: /nix/store/{hash}-glu-9.0.1/lib/libGLU.so: invalid string offset 1353 >= 1011 for section `.strtab'
@thefloweringash
Copy link
Member Author

thefloweringash commented May 14, 2020

The binutils update (#86954) is now in staging. Let's go with that instead.

@thefloweringash thefloweringash deleted the thefloweringash:binutils-armv7 branch May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.