Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

b4: init at 0.4.0 #86558

Open
wants to merge 2 commits into
base: master
from
Open

b4: init at 0.4.0 #86558

wants to merge 2 commits into from

Conversation

@matthiasbeyer
Copy link
Contributor

matthiasbeyer commented May 2, 2020

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@@ -490,6 +490,8 @@ in {

azure-multiapi-storage = callPackage ../development/python-modules/azure-multiapi-storage { };

b4 = callPackage ../applications/version-management/git-and-tools/b4 { };

This comment has been minimized.

Copy link
@jonringer

jonringer May 3, 2020

Contributor

python-modules shouldn't contain a buildPythonApplication. The package won't appear to downstream dependencies.

If you want to package this a python module, please use buildPythonPackage or pythonXPackages.toPythonModule

This comment has been minimized.

Copy link
@matthiasbeyer

matthiasbeyer May 3, 2020

Author Contributor

It is a application though, a commandline utility.

This comment has been minimized.

Copy link
@jonringer

jonringer May 4, 2020

Contributor

buildPythonPackage will still show entry points as command line utilities, the difference is in downstream dependencies. Please read https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/python.section.md#building-packages-and-applications

@ofborg ofborg bot removed the 6.topic: python label May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.