Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add section on running ad-hoc Perl programs to the nixpkgs manual #86589

Open
wants to merge 1 commit into
base: master
from

Conversation

@raboof
Copy link
Contributor

raboof commented May 2, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@raboof raboof changed the title Add section on running ad-hoc Perl programs to the nixpkgs manual doc: add section on running ad-hoc Perl programs to the nixpkgs manual May 2, 2020
@raboof
Copy link
Contributor Author

raboof commented Jul 7, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label Jul 7, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Jul 7, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@timokau
Copy link
Member

timokau commented Jul 8, 2020

Looks like I missed one bot error due to the issue yesterday.
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot requested a review from fgaz Jul 8, 2020
<programlisting>
foo = import ../path/to/foo.nix {
inherit stdenv fetchurl ...;
inherit (perlPackages) ClassC3;

This comment has been minimized.

Copy link
@Mic92

Mic92 Jul 8, 2020

Contributor

We don't have a perlPackages.callPackage scope like we do have for python?

This comment has been minimized.

Copy link
@Mic92

Mic92 Jul 8, 2020

Contributor

Actually we do...

foo = perlPackages.callPackage ./path/to/foo.nix {};

should fill out:

{ ClassC3 }:
# ...

This comment has been minimized.

Copy link
@Mic92

Mic92 Jul 8, 2020

Contributor

I am not actually sure which section was actually changed so I read the whole article.

@marvin-mk2 marvin-mk2 bot requested a review from timokau Jul 14, 2020
Copy link
Member

timokau left a comment

See @Mic92's feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.