Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pylibftdi: point to correct libusb library #86602

Merged
merged 2 commits into from May 2, 2020
Merged

Conversation

@matthuszagh
Copy link
Contributor

matthuszagh commented May 2, 2020

Motivation for this change

@veprbl I missed this issue before. libusb library is libusb-1.0.so. libftdi is fine.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@matthuszagh matthuszagh requested review from FRidh and jonringer as code owners May 2, 2020
@veprbl
veprbl approved these changes May 2, 2020
Copy link
Member

veprbl left a comment

LGTM

httpserver is only used in an example, and prevents python2 builds
from working.
@prusnak
prusnak approved these changes May 2, 2020
@matthuszagh
Copy link
Contributor Author

matthuszagh commented May 2, 2020

I added another commit removing the httpserver dependency. This is only used in an example and prevents pylibftdi from working with python2.

@prusnak
prusnak approved these changes May 2, 2020
@veprbl veprbl merged commit 434cf0f into NixOS:master May 2, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="495ac69"; rev="495ac69605a08b8b5f60c25a459e4d22376e4031"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="495ac69"; rev="495ac69605a08b8b5f60c25a459e4d22376e4031"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="495ac69"; rev="495ac69605a08b8b5f60c25a459e4d22376e4031"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="495ac69"; rev="495ac69605a08b8b5f60c25a459e4d22376e4031"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="495ac69"; rev="495ac69605a08b8b5f60c25a459e4d22376e4031"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="495ac69"; rev="495ac69605a08b8b5f60c25a459e4d22376e4031"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="495ac69"; rev="495ac69605a08b8b5f60c25a459e4d22376e4031"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@matthuszagh matthuszagh deleted the matthuszagh:pylibftdi branch May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.