Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.03] keybase,kbfs,keybase-gui: 5.0.0 -> 5.4.2 #86604

Merged

Conversation

@fabianhjr
Copy link
Contributor

fabianhjr commented May 2, 2020

Motivation for this change

Keybase has shipped many bugfixes and an essential features (blocking other people) since this is a security focused tool backporting this version upgrades from nixpkgs/master would be desirable.

Bufixes of features available on 5.0.0 from upstream:

5.1.0:

  • Various bug fixes around team management
  • Dark mode fixes
  • Smaller bug fixes and performance improvements

5.1.1:

  • This is a bugfix release.
  • Enabled blocking users from their profile

5.2.0:

  • Various bug fixes and performance improvements.

5.2.1:

  • This is a bugfix release.

5.3.0:

  • Many performance improvements and bug fixes

5.3.1:

  • This is a bugfix release.

5.4.0:
n/a (only feature additions and fixes of feature additions after 5.0.0)

5.4.1:

  • Fix KBFS performance issues

5.4.2:

  • This is a bugfix release for KBFS performance.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Avaq
Copy link
Member

Avaq commented May 2, 2020

I just built this on nixos with sandboxing and verified that kbfs, keybase, keybase-gui and the keybase daemon are working as expected.

@bhipple
Copy link
Contributor

bhipple commented May 3, 2020

Result of nixpkgs-review pr 86604 1

3 packages built:
- kbfs
- keybase
- keybase-gui
@bhipple
bhipple approved these changes May 3, 2020
@bhipple bhipple merged commit c0137eb into NixOS:release-20.03 May 3, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="eaae309"; rev="eaae309039837df0e33389f1c362292b4e0df504"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="eaae309"; rev="eaae309039837df0e33389f1c362292b4e0df504"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="eaae309"; rev="eaae309039837df0e33389f1c362292b4e0df504"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="eaae309"; rev="eaae309039837df0e33389f1c362292b4e0df504"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="eaae309"; rev="eaae309039837df0e33389f1c362292b4e0df504"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="eaae309"; rev="eaae309039837df0e33389f1c362292b4e0df504"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="eaae309"; rev="eaae309039837df0e33389f1c362292b4e0df504"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
kbfs, kbfs.passthru.tests, keybase, keybase-gui, keybase-gui.passthru.tests, keybase.passthru.tests on aarch64-linux Success
Details
kbfs, kbfs.passthru.tests, keybase, keybase-gui, keybase-gui.passthru.tests, keybase.passthru.tests on x86_64-linux Success
Details
@drewrisinger drewrisinger mentioned this pull request May 3, 2020
4 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.