Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sooperlooper: Add alsa library build dependency #86607

Closed
wants to merge 1 commit into from

Conversation

@kasimon
Copy link
Contributor

kasimon commented May 2, 2020

Motivation for this change

Currently, sooperlooper is built without alsa support:

checking alsa/asoundlib.h usability... no
checking alsa/asoundlib.h presence... no
checking for alsa/asoundlib.h... no

This causes sooperlooper to have no midi ports, which prevents it from being controlled by a hardware midi controller.

Things done

This change adds alsaLib as a build dependency. With this change the package is build with support for alsa midi ports.

This is my very first nixpkgs pull request, if anything is suboptimal I will happily fix it. Just give me a note.

I have built and tested the package on nixOS 20.03 without problems. The change should not affect any other package.

  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Currently, sooperlooper is built without alsa support:

    checking alsa/asoundlib.h usability... no
    checking alsa/asoundlib.h presence... no
    checking for alsa/asoundlib.h... no

This causes sooperlooper to have no midi ports, which prevents it from
being controlled by a hardware midi controller.

This change adds alsaLib as a build dependency. With this change the package
is build with support for alsa midi ports.

This is my very first nixpkgs pull request, if anything is suboptimal I will
happily fix it.
@prusnak
Copy link
Member

prusnak commented May 2, 2020

While reviewing your PR I noticed the package could be updated and there is another dependency (fftw) missing. I created new PR here: #86610 - can you please review this one whether it works for you? Thanks!

@prusnak prusnak closed this May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.