Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plasma5.kwin: add mesa dependency #86615

Merged
merged 1 commit into from May 11, 2020
Merged

plasma5.kwin: add mesa dependency #86615

merged 1 commit into from May 11, 2020

Conversation

@shatsky
Copy link
Contributor

shatsky commented May 2, 2020

mesa provides libgbm required to build kwin_wayland drm backend with hw accel (compositing&clients)

Motivation for this change

This is required to get Plasma Wayland working on NixOS. See #43757 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after); 1477060368->1477108696
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

To be precise I've tested not this commit but the local one; I've branched from recent nixos-20.03 commit which my system is built from and applied the same patch. I hope it's OK.

mesa provides libgbm required to build kwin_wayland drm backend with hw accel (compositing&clients)
@ttuegel ttuegel merged commit e154c6c into NixOS:master May 11, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="aa0574e"; rev="aa0574e394136b2e154438b64b3019c8338de757"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="aa0574e"; rev="aa0574e394136b2e154438b64b3019c8338de757"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="aa0574e"; rev="aa0574e394136b2e154438b64b3019c8338de757"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="aa0574e"; rev="aa0574e394136b2e154438b64b3019c8338de757"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="aa0574e"; rev="aa0574e394136b2e154438b64b3019c8338de757"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="aa0574e"; rev="aa0574e394136b2e154438b64b3019c8338de757"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="aa0574e"; rev="aa0574e394136b2e154438b64b3019c8338de757"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
plasma5.kwin, plasma5.kwin.passthru.tests on aarch64-linux Success
Details
plasma5.kwin, plasma5.kwin.passthru.tests on x86_64-linux Success
Details
@ttuegel
Copy link
Member

ttuegel commented May 11, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.