Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python.pkgs.binwalk: remove p7zip from propagatedBuildInputs #86621

Merged
merged 1 commit into from May 3, 2020

Conversation

@flokli
Copy link
Contributor

flokli commented May 2, 2020

p7zip is abandoned and may not receive important security fixes.

It was marked as insecure in aa80b47

binwalk might loose the possibility to extract some binary formats,
but it's better than running it on untrusted imput.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
p7zip is abandoned and may not receive important security fixes.

It was marked as insecure in aa80b47

`binwalk` might loose the possibility to extract some binary formats,
but it's better than running it on untrusted imput.
@flokli
Copy link
Contributor Author

flokli commented May 2, 2020

I also opened ReFirmLabs/binwalk#460 to inform binwalk about this.

@bhipple
Copy link
Contributor

bhipple commented May 3, 2020

Seems reasonable to me.

@bhipple
Copy link
Contributor

bhipple commented May 3, 2020

Result of nixpkgs-review pr 86621 1

3 packages built:
- python27Packages.binwalk (python27Packages.binwalk-full)
- python37Packages.binwalk (python37Packages.binwalk-full)
- python38Packages.binwalk (python38Packages.binwalk-full)
@bhipple
bhipple approved these changes May 3, 2020
@bhipple bhipple merged commit f17f830 into NixOS:master May 3, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9a2ec56"; rev="9a2ec56ad4587b3aa3777e6fd480980c4d51b292"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9a2ec56"; rev="9a2ec56ad4587b3aa3777e6fd480980c4d51b292"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9a2ec56"; rev="9a2ec56ad4587b3aa3777e6fd480980c4d51b292"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9a2ec56"; rev="9a2ec56ad4587b3aa3777e6fd480980c4d51b292"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9a2ec56"; rev="9a2ec56ad4587b3aa3777e6fd480980c4d51b292"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9a2ec56"; rev="9a2ec56ad4587b3aa3777e6fd480980c4d51b292"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9a2ec56"; rev="9a2ec56ad4587b3aa3777e6fd480980c4d51b292"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.