Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unar: 1.10.1 -> 1.10.7 #86628

Merged
merged 1 commit into from May 3, 2020
Merged

unar: 1.10.1 -> 1.10.7 #86628

merged 1 commit into from May 3, 2020

Conversation

@peterhoeg
Copy link
Member

peterhoeg commented May 3, 2020

Motivation for this change

Quite a lot of fixes upstream and build from the public repo as opposed
to a zip file that was out of date anyway.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@peterhoeg
Copy link
Member Author

peterhoeg commented May 3, 2020

I was using 7z as my general unpacker and obviously needed a substitute. Someone mentioned unar which was probably just as riddled with exploits waiting to be taken advantage of as it hadn't been updated in years either, so this changes it to a recent, supported version.

Further to #86417 and #85780.

@nixos-discourse
Copy link

nixos-discourse commented May 3, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/p7zip-and-possible-rces/6951/10

@Elyhaka
Copy link
Contributor

Elyhaka commented May 3, 2020

I'm currently testing this PR (as a replacement for the old p7zip) and I couldn't manage to build it:

gcc: error: unar.m: Objective-C compiler not installed on this system
gcc: error: CommandLineCommon.m: Objective-C compiler not installed on this system

Any suggestions ?

@mweinelt
Copy link
Member

mweinelt commented May 3, 2020

❯ nixpkgs-review pr 86628
[...]
2 packages built:
bookworm unar

The binaries are executable. LGTM.

@peterhoeg
Copy link
Member Author

peterhoeg commented May 3, 2020

and I couldn't manage to build it:

I'm not sure what problem you hit, but it builds and runs for both me and @mweinelt as well as @GrahamcOfBorg.

@peterhoeg peterhoeg merged commit 5fda26c into NixOS:master May 3, 2020
16 checks passed
16 checks passed
unar, unar.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="991c4d4"; rev="991c4d48db1d0917434633d28e13d54199abaea5"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="991c4d4"; rev="991c4d48db1d0917434633d28e13d54199abaea5"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="991c4d4"; rev="991c4d48db1d0917434633d28e13d54199abaea5"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="991c4d4"; rev="991c4d48db1d0917434633d28e13d54199abaea5"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="991c4d4"; rev="991c4d48db1d0917434633d28e13d54199abaea5"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="991c4d4"; rev="991c4d48db1d0917434633d28e13d54199abaea5"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="991c4d4"; rev="991c4d48db1d0917434633d28e13d54199abaea5"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
unar, unar.passthru.tests on x86_64-linux Success
Details
@peterhoeg
Copy link
Member Author

peterhoeg commented May 3, 2020

And thanks for verifying it all!

@peterhoeg peterhoeg deleted the peterhoeg:f/unar branch May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.