Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undervolt: Make timer optional #86632

Open
wants to merge 3 commits into
base: master
from
Open

Conversation

@Atemu
Copy link
Member

Atemu commented May 3, 2020

Motivation for this change

The undervolt timer applies the undervolt every 30s which spams the journal. IIRC this was done because the undervolt would not survive certain events (reboot, resume).

I have been running these patches for ~3 months and the undervolt holds perfectly on my Broadwell convertible. I don't know if he tested them long-term but they also worked on my friend's Coffelake laptop.
More test results welcome.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Lassulus
Copy link
Contributor

Lassulus commented May 5, 2020

hmm, this could break the setup for some people. Maybe add a notice to https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2009.xml ?

@Atemu
Copy link
Member Author

Atemu commented May 6, 2020

Sure, I've never written docbook before but I'm sure I can manage.

How can I build the release notes to verify they look correct?

@Lassulus
Copy link
Contributor

Lassulus commented May 12, 2020

Oh sorry, I missed the notification.
In the root of nixpkgs you can run nix-build nixos/release.nix -A manual.x86_64-linux this outputs a path to the nix-store. In the generated path you will find the html at /share/doc/nixos/index.html

Atemu added 3 commits Feb 22, 2020
The undervolt did not persist reboots or sleep/hibernation. With this
change you should no longer have to apply the undervolt on a timer
It should no longer be needed but is worth keeping around in case it is
@Atemu Atemu force-pushed the Atemu:undervolt-timer-optional branch from 426ba45 to 39ef28b Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.