Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zsh: added option to enable compatibility with bash's completion system #86643

Merged
merged 1 commit into from May 19, 2020

Conversation

@asbachb
Copy link
Contributor

asbachb commented May 3, 2020

Motivation for this change

Added ability to add bashcompinit to system wide zshrc configuration.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
 asbachb@nixos  ~/dev/src/nix/nixpkgs   zsh-bash-autocomplete  nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
these paths will be fetched (0.08 MiB download, 0.40 MiB unpacked):
  /nix/store/0rbnlnd1pvlpii8p72ybvvg672j2wc2f-bash-interactive-4.4-p23-dev
  /nix/store/c0j7hbxbffh08la9bp90dxqx8s1xm1xp-nixpkgs-review-2.3.0
copying path '/nix/store/0rbnlnd1pvlpii8p72ybvvg672j2wc2f-bash-interactive-4.4-p23-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/c0j7hbxbffh08la9bp90dxqx8s1xm1xp-nixpkgs-review-2.3.0' from 'https://cache.nixos.org'...
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
From https://github.com/NixOS/nixpkgs
   05f0934825c..776f12b39ec  master     -> refs/nixpkgs-review/0
$ git worktree add /home/asbachb/.cache/nixpkgs-review/rev-400baf9946ae1ba7e73a5b931c64f91415be5eed-dirty/nixpkgs 776f12b39ec436ea31c57ecf755464b175d765d9
Preparing worktree (detached HEAD 776f12b39ec)
Updating files: 100% (21628/21628), done.
HEAD is now at 776f12b39ec Merge pull request #86401 from etu/php-add-doc-to-index
$ nix-env -f /home/asbachb/.cache/nixpkgs-review/rev-400baf9946ae1ba7e73a5b931c64f91415be5eed-dirty/nixpkgs -qaP --xml --out-path --show-trace
No diff detected, stopping review...
$ git worktree prune
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@asbachb
Copy link
Contributor Author

asbachb commented May 3, 2020

fyi zsh maintainer @pSub

@Ma27 Ma27 merged commit 5d0fc0f into NixOS:master May 19, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cbb5b57"; rev="cbb5b578b881b01c570e882088bd0869bea15971"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cbb5b57"; rev="cbb5b578b881b01c570e882088bd0869bea15971"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cbb5b57"; rev="cbb5b578b881b01c570e882088bd0869bea15971"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cbb5b57"; rev="cbb5b578b881b01c570e882088bd0869bea15971"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cbb5b57"; rev="cbb5b578b881b01c570e882088bd0869bea15971"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cbb5b57"; rev="cbb5b578b881b01c570e882088bd0869bea15971"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cbb5b57"; rev="cbb5b578b881b01c570e882088bd0869bea15971"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
zsh, zsh.passthru.tests on aarch64-linux Success
Details
zsh, zsh.passthru.tests on x86_64-linux Success
Details
@asbachb asbachb deleted the asbachb:zsh-bash-autocomplete branch Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.