Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
nixos/prosody: add MUC extraConfig + fixes #86649
Thanks for the work in #86067 @NinjaTrappeur, even though it probably wasn't the goal it makes the Jitsi Meet module compose better with user-defined Prosody configuration! I'd like to propose for a few modifications in this PR:
Motivation for this change
Btw the jitsi module now only uses global
I'm wondering whether it would make sense to extend the Prosody module with options for external components. The
This test, together with the two prosody ones were broken for a long time actually. The
After a quick scan, it looks like the ebjabberd test is lacking the http_upload support, which we now aim to ship by default, we'll definitely need to setup this module for this test to pass.
I added this to my todo list.
This matter is however out of scope for this PR, let's merge this ;)
Add extraConfig option for the muc submodule. Also move the global extraConfig before all components and virtualhosts, because the manual states: The configuration is divided into two parts. The first part is known as the "global" section. All settings here apply to the whole server, and are the default for all virtual hosts. The second half of the file is a series of VirtualHost and Component definitions. Settings under each VirtualHost or Component line apply only to that host. Before, if at least one muc was defined, or uploadHttp enabled, the global extraConfig would end up after "muc" or "http_upload" component making it apply to that component only and not globally.