Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.python-telegram-bot: 12.3.0 -> 12.7 #86652

Merged
merged 2 commits into from May 3, 2020

Conversation

@pingiun
Copy link
Member

@pingiun pingiun commented May 3, 2020

Motivation for this change

Update the python-telegram-bot package. Also removed the hacky way to avoid vendored urllib and replaced with --with-upstream-urllib3 option

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (but with small bot instead)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

@jonringer jonringer left a comment

otherwise LGTM

Co-authored-by: Jon <jonringer@users.noreply.github.com>
@jonringer jonringer merged commit 5b49946 into NixOS:master May 3, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0a4c59d"; rev="0a4c59d35794b43098260df4516400be446a2770"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0a4c59d"; rev="0a4c59d35794b43098260df4516400be446a2770"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0a4c59d"; rev="0a4c59d35794b43098260df4516400be446a2770"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0a4c59d"; rev="0a4c59d35794b43098260df4516400be446a2770"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0a4c59d"; rev="0a4c59d35794b43098260df4516400be446a2770"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0a4c59d"; rev="0a4c59d35794b43098260df4516400be446a2770"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0a4c59d"; rev="0a4c59d35794b43098260df4516400be446a2770"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@jonringer
Copy link
Contributor

@jonringer jonringer commented May 3, 2020

squashed and merged

evanjs added a commit to evanjs/nixpkgs that referenced this pull request May 3, 2020
* python3Packages.python-telegram-bot: 12.3.0 -> 12.7

* Update pkgs/development/python-modules/python-telegram-bot/default.nix

Co-authored-by: Jon <jonringer@users.noreply.github.com>

Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
Co-authored-by: Jon <jonringer@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.