Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zoxide: 0.3.1 -> 0.4.0 #86658

Merged
merged 1 commit into from May 3, 2020
Merged

zoxide: 0.3.1 -> 0.4.0 #86658

merged 1 commit into from May 3, 2020

Conversation

@cole-h
Copy link
Member

cole-h commented May 3, 2020

ajeetdsouza/zoxide@v0.3.1...v0.4.0

Most notable changes, IMHO:

  • zoxide init now uses PWD hooks by default
  • fish no longer cds to the user's home when no match is found
  • Interactive mode in zoxide no longer throws an error if fzf exits gracefully
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
ajeetdsouza/zoxide@v0.3.1...v0.4.0

Most notable changes, IMHO:

- `zoxide init` now uses PWD hooks by default
- `fish` no longer `cd`s to the user's home when no match is found
- Interactive mode in `zoxide` no longer throws an error if `fzf` exits gracefully
@prusnak
prusnak approved these changes May 3, 2020
@dywedir
Copy link
Contributor

dywedir commented May 3, 2020

Thanks!

@dywedir dywedir merged commit e09bdc1 into NixOS:master May 3, 2020
17 checks passed
17 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fb7e28e"; rev="fb7e28ebbec02cdf6f3a6ba474c86ffdce87975e"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fb7e28e"; rev="fb7e28ebbec02cdf6f3a6ba474c86ffdce87975e"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fb7e28e"; rev="fb7e28ebbec02cdf6f3a6ba474c86ffdce87975e"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fb7e28e"; rev="fb7e28ebbec02cdf6f3a6ba474c86ffdce87975e"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fb7e28e"; rev="fb7e28ebbec02cdf6f3a6ba474c86ffdce87975e"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fb7e28e"; rev="fb7e28ebbec02cdf6f3a6ba474c86ffdce87975e"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fb7e28e"; rev="fb7e28ebbec02cdf6f3a6ba474c86ffdce87975e"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
zoxide, zoxide.passthru.tests on aarch64-linux Success
Details
zoxide, zoxide.passthru.tests on x86_64-darwin Success
Details
zoxide, zoxide.passthru.tests on x86_64-linux Success
Details
@cole-h cole-h deleted the cole-h:zoxide branch May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.