Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
chromium: Add missing dependency on gnugrep #86662
The bin script that runs chromium calls out to gnugrep:
but gnugrep ismissing as a runtime dependency of the chromium package. I found thisout when I was trying to put it in a docker image and was getting errors that grep didn't exist.
I'm a little unfamiliar with how makeWrapper works, so this may not actually be the right way to include this - I'm mostly submitting this as a call for help, because it felt broken to me.
Motivation for this change
This change doesn't look like it should fix the issue. Did it actually fix it in practice?
The reason I don't think it fixes the issue is because the grep issue is a runtime dependency (in the wrapper script), and you added it as a buildInput only... but a buildInput doesn't end up as a runtime dependency unless there's a reference to it in one of the output artifacts.
Because of that, I think you'll also want to add an explicit reference to the gnugrep derivation. Specifically, the following line could be changed to add the runtime reference:
If we change that to
The bin script that runs chromium calls out to gnugrep - but gnugrep is missing as a runtime dependency of the chromium package. I found this out when I was trying to put it in a docker image.