Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xp-pen-g430: rename to pentablet-driver & 20190820 -> 1.2.13.1 #86666

Merged
merged 2 commits into from May 6, 2020

Conversation

@IvarWithoutBones
Copy link
Contributor

IvarWithoutBones commented May 3, 2020

Motivation for this change

Renamed the xp-pen-g430 package to pentablet-driver, as i noticed all drivers in this series are exactly the same. Also updated it from 20190820 -> 1.2.13.1.

I'm copying them to $out/bin seperately now as to not have the annoying capitalization of the executable. Note that config.xml has to be next to the executable for it to start.

Their versioning is a tad confusing but this came out like 5 months later, so I'm sure it's newer.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

prusnak left a comment

Maybe also add the following to the pkgs/top-level/aliases.nix:

xp-pen-g430 = pentablet-driver; # added 2020-05-03
@IvarWithoutBones IvarWithoutBones force-pushed the IvarWithoutBones:pentablet-driver branch from 490d91b to 408835d May 3, 2020
@IvarWithoutBones
Copy link
Contributor Author

IvarWithoutBones commented May 3, 2020

Maybe also add the following to the pkgs/top-level/aliases.nix:

xp-pen-g430 = pentablet-driver; # added 2020-05-03

Done 👍

Edit: Oops, had a typo. fixed.

@IvarWithoutBones IvarWithoutBones force-pushed the IvarWithoutBones:pentablet-driver branch from 408835d to 717fb14 May 3, 2020
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@IvarWithoutBones IvarWithoutBones force-pushed the IvarWithoutBones:pentablet-driver branch from 717fb14 to daf860d May 3, 2020
@ofborg ofborg bot removed the 10.rebuild-linux: 1 label May 3, 2020
@prusnak
prusnak approved these changes May 3, 2020
@ofborg ofborg bot added the 10.rebuild-linux: 1 label May 3, 2020
@veprbl veprbl merged commit f46cbbc into NixOS:master May 6, 2020
16 checks passed
16 checks passed
pentablet-driver, pentablet-driver.passthru.tests on aarch64-linux No attempt
Details
pentablet-driver, pentablet-driver.passthru.tests on x86_64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="daf860d"; rev="daf860d9fe9d10a2f7e3f86037f9472b30626ed1"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="daf860d"; rev="daf860d9fe9d10a2f7e3f86037f9472b30626ed1"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="daf860d"; rev="daf860d9fe9d10a2f7e3f86037f9472b30626ed1"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="daf860d"; rev="daf860d9fe9d10a2f7e3f86037f9472b30626ed1"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="daf860d"; rev="daf860d9fe9d10a2f7e3f86037f9472b30626ed1"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="daf860d"; rev="daf860d9fe9d10a2f7e3f86037f9472b30626ed1"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="daf860d"; rev="daf860d9fe9d10a2f7e3f86037f9472b30626ed1"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@IvarWithoutBones IvarWithoutBones deleted the IvarWithoutBones:pentablet-driver branch May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.