Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria2: add libaria2 support #86671

Merged
merged 1 commit into from May 12, 2020
Merged

aria2: add libaria2 support #86671

merged 1 commit into from May 12, 2020

Conversation

@bachp
Copy link
Member

bachp commented May 3, 2020

This changes the derivation to be a multi output derivation
and at the same time builds the binary against the shared libaria2.

Motivation for this change

Make libaria2 available for other packages and at the same time use it in the aria2c binary.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
This changes the derivation to be a multi output derivation
and at the same time builds the binary against the shared libaria2.
@Lassulus Lassulus merged commit d630d0e into NixOS:master May 12, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
aria2, aria2.passthru.tests on aarch64-linux Success
Details
aria2, aria2.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="020d0bf"; rev="020d0bfe1aec36a170f31e1239493946fe216735"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="020d0bf"; rev="020d0bfe1aec36a170f31e1239493946fe216735"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="020d0bf"; rev="020d0bfe1aec36a170f31e1239493946fe216735"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="020d0bf"; rev="020d0bfe1aec36a170f31e1239493946fe216735"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="020d0bf"; rev="020d0bfe1aec36a170f31e1239493946fe216735"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="020d0bf"; rev="020d0bfe1aec36a170f31e1239493946fe216735"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="020d0bf"; rev="020d0bfe1aec36a170f31e1239493946fe216735"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@bachp bachp deleted the bachp:libaria2 branch May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.