Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/picom: cleanup #86678

Merged
merged 2 commits into from May 6, 2020
Merged

nixos/picom: cleanup #86678

merged 2 commits into from May 6, 2020

Conversation

@rnhmjoj
Copy link
Contributor

rnhmjoj commented May 3, 2020

Motivation for this change

Fix the ugly type in #86402 and clean up the module.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested Picom with various configuration in a VM
  • Built manual
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
rnhmjoj added 2 commits May 2, 2020
- Use floating points instead of strings, which Nix now supports

- Make the type of picom.settings option recursive

- Add a meaningful description of both the option and its type
@rnhmjoj rnhmjoj force-pushed the rnhmjoj:picom branch from 6df3c95 to 027d4e6 May 4, 2020
@rnhmjoj rnhmjoj requested review from eadwu, adisbladis and JohnAZoidberg May 4, 2020
@eadwu
eadwu approved these changes May 4, 2020
Copy link
Member

eadwu left a comment

Working fine for me

@rnhmjoj rnhmjoj merged commit dc9c88a into NixOS:master May 6, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="027d4e6"; rev="027d4e639a665a13827852bc4b1b80f706b274b2"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="027d4e6"; rev="027d4e639a665a13827852bc4b1b80f706b274b2"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="027d4e6"; rev="027d4e639a665a13827852bc4b1b80f706b274b2"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="027d4e6"; rev="027d4e639a665a13827852bc4b1b80f706b274b2"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="027d4e6"; rev="027d4e639a665a13827852bc4b1b80f706b274b2"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="027d4e6"; rev="027d4e639a665a13827852bc4b1b80f706b274b2"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="027d4e6"; rev="027d4e639a665a13827852bc4b1b80f706b274b2"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@nixos-discourse

This comment has been minimized.

Copy link

nixos-discourse commented on 1b9f81c May 16, 2020

This commit has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nixos-rebuild-error-in-services-picom-activeopacity/7219/1

@rnhmjoj rnhmjoj deleted the rnhmjoj:picom branch Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.