Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitqlient: init at 1.1.0 #86706

Draft
wants to merge 1 commit into
base: master
from
Draft

gitqlient: init at 1.1.0 #86706

wants to merge 1 commit into from

Conversation

@colemickens
Copy link
Contributor

colemickens commented May 4, 2020

Motivation for this change

Fixes: #86702.

Seems to build, launch, run okay. Going to test for a bit, maybe wait for the actual 1.1.0 release and then mark this as not-Draft.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
, qtbase, qmake
}:

with stdenv.lib;

This comment has been minimized.

Copy link
@prusnak

prusnak May 4, 2020

Member

Remove this line

mv $out/homeless-shelter/GitQlient/bin $out/bin
'';

meta = {

This comment has been minimized.

Copy link
@prusnak

prusnak May 4, 2020

Member
Suggested change
meta = {
meta = with stdenv.lib; {
@@ -3693,6 +3693,8 @@ in

gitaly = callPackage ../applications/version-management/gitlab/gitaly { };

gitqlient = qt5.callPackage ../applications/version-management/gitqlient { };

This comment has been minimized.

Copy link
@prusnak

prusnak May 4, 2020

Member

It seems it is much more common to use

Suggested change
gitqlient = qt5.callPackage ../applications/version-management/gitqlient { };
gitqlient = libsForQt5.callPackage ../applications/version-management/gitqlient { };
@@ -0,0 +1,34 @@
{ stdenv, mkDerivation, fetchFromGitHub

This comment has been minimized.

Copy link
@prusnak

prusnak May 4, 2020

Member

Remove stdenv

buildInputs = [ qtbase ];
nativeBuildInputs = [ qmake ];
Comment on lines +19 to +20

This comment has been minimized.

Copy link
@prusnak

prusnak May 4, 2020

Member

Not sure if these 2 lines are required when you use libsForQt5 in all-packages.nix.


meta = {
homepage = "https://github.com/francescmm/GitQlient";
description = "GitQlient: Multi-platform Git client written with Qt";

This comment has been minimized.

Copy link
@prusnak

prusnak May 4, 2020

Member
Suggested change
description = "GitQlient: Multi-platform Git client written with Qt";
description = "Multi-platform Git client written with Qt";
@colemickens colemickens force-pushed the colemickens:gitqlient branch 4 times, most recently from 1eb4758 to f2ea8cc Jun 29, 2020
@colemickens colemickens changed the title gitqlient: init at 1.1.0-beta gitqlient: init at 1.1.0 Jul 6, 2020
@colemickens colemickens force-pushed the colemickens:gitqlient branch from f2ea8cc to 6b8d609 Jul 7, 2020
@colemickens colemickens force-pushed the colemickens:gitqlient branch from 6b8d609 to f183603 Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.