Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onedrive: 2.3.13 -> 2.4.1 #86707

Open
wants to merge 1 commit into
base: master
from
Open

Conversation

@r-ryantm
Copy link
Contributor

r-ryantm commented May 4, 2020

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/abraunegg/onedrive/releases.

meta.description for onedrive is: "A complete tool to interact with OneDrive on Linux"

meta.homepage for onedrive is: "https://github.com/abraunegg/onedrive"

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)

Rebuild report (if merged into master) (click to expand)
3 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
onedrive
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/48kf75ci42476k4nhi8gs7djx941b2yp-onedrive-2.4.1 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A onedrive https://github.com/r-ryantm/nixpkgs/archive/22f5362ed9ae3bb7ae77fe106d582b082f3319cc.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/48kf75ci42476k4nhi8gs7djx941b2yp-onedrive-2.4.1
ls -la /nix/store/48kf75ci42476k4nhi8gs7djx941b2yp-onedrive-2.4.1/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the change, simply because they are already broken on the target branch.

Result of nixpkgs-review 1

1 package built:
- onedrive

Maintainer pings

cc @SRGOM @ianmjones for testing.

Copy link
Member

ianmjones left a comment

@SRGOM I'm currently not running NixOS and therefore not using this onedrive package.

As I am unable to review this PR, feel free to handle this PR as you see fit.

Please remove me as a maintainer of the package in your next update too (assuming you're still maintaining it). 🙏

@fadenb
fadenb approved these changes May 25, 2020
Copy link
Member

fadenb left a comment

Just build the application with this patch on top and it seems to work fine (it is my first time using it so I may not know all the details to look out for yet).

The current 2.3.13 does no longer work with OneDrive (for Business).
We should think about backporting it to stable.

@SRGOM SRGOM mentioned this pull request May 26, 2020
5 of 10 tasks complete
Copy link
Member

ryantm left a comment

Close this after @SRGOM 's PR is merged.

@SRGOM
Copy link
Member

SRGOM commented May 29, 2020

I will, I prefer my pr because it has doc changes which explain how to handle a breakage. I will bump up too.

@SRGOM SRGOM mentioned this pull request May 30, 2020
5 of 10 tasks complete
@r-ryantm r-ryantm closed this Jun 11, 2020
@r-ryantm r-ryantm deleted the r-ryantm:auto-update/onedrive branch Jun 11, 2020
@ryantm ryantm restored the r-ryantm:auto-update/onedrive branch Jun 11, 2020
@ryantm ryantm reopened this Jun 11, 2020
@ofborg ofborg bot requested review from ianmjones and removed request for SRGOM Jun 11, 2020
@r-ryantm r-ryantm closed this Jun 14, 2020
@r-ryantm r-ryantm deleted the r-ryantm:auto-update/onedrive branch Jun 14, 2020
@ryantm ryantm restored the r-ryantm:auto-update/onedrive branch Jun 14, 2020
@ryantm ryantm reopened this Jun 14, 2020
@r-ryantm r-ryantm closed this Jul 1, 2020
@r-ryantm r-ryantm deleted the r-ryantm:auto-update/onedrive branch Jul 1, 2020
@ryantm ryantm restored the r-ryantm:auto-update/onedrive branch Jul 1, 2020
@ryantm ryantm reopened this Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.