Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osmium-tool: 1.11.1 -> 1.12.0 #86714

Merged
merged 1 commit into from May 4, 2020
Merged

Conversation

@r-ryantm
Copy link
Contributor

r-ryantm commented May 4, 2020

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/osmcode/osmium-tool/releases.

meta.description for osmium-tool is: "Multipurpose command line tool for working with OpenStreetMap data based on the Osmium library"

meta.homepage for osmium-tool is: "https://osmcode.org/osmium-tool/"

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)

Rebuild report (if merged into master) (click to expand)
1 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
0 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
0 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
osmium-tool
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/mfmnmsfs06crlg6wk2a1vwjp6dmjyd6d-osmium-tool-1.12.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A osmium-tool https://github.com/r-ryantm/nixpkgs/archive/c241a4c58fb795cfa103cc58f8a71a7f4a593b9e.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/mfmnmsfs06crlg6wk2a1vwjp6dmjyd6d-osmium-tool-1.12.0
ls -la /nix/store/mfmnmsfs06crlg6wk2a1vwjp6dmjyd6d-osmium-tool-1.12.0/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the change, simply because they are already broken on the target branch.

Result of nixpkgs-review 1

1 package built:
- osmium-tool

Maintainer pings

cc @das-g for testing.

@das-g
das-g approved these changes May 4, 2020
Copy link
Member

das-g left a comment

Diff LGTM.

Tests done:

  • download from Cachix:
    nix-store -r /nix/store/mfmnmsfs06crlg6wk2a1vwjp6dmjyd6d-osmium-tool-1.12.0 \
      --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
      --option trusted-public-keys '
      r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      '
  • checked that the osmium binary is still the only file installed by the package
    nix run nixpkgs.tree -c tree /nix/store/mfmnmsfs06crlg6wk2a1vwjp6dmjyd6d-osmium-tool-1.12.0
    /nix/store/mfmnmsfs06crlg6wk2a1vwjp6dmjyd6d-osmium-tool-1.12.0
    └── bin
        └── osmium
    
    1 directory, 1 file
    
  • smoke-tested the included binary:
    • /nix/store/mfmnmsfs06crlg6wk2a1vwjp6dmjyd6d-osmium-tool-1.12.0/bin/osmium --version
      osmium version 1.12.0
      libosmium version 2.15.4
      Copyright (C) 2013-2020  Jochen Topf <jochen@topf.org>
      License: GNU GENERAL PUBLIC LICENSE Version 3 <https://gnu.org/licenses/gpl.html>.
      This is free software: you are free to change and redistribute it.
      There is NO WARRANTY, to the extent permitted by law.
      
    • /nix/store/mfmnmsfs06crlg6wk2a1vwjp6dmjyd6d-osmium-tool-1.12.0/bin/osmium fileinfo $SOME_PBF_FILE
      (output looked sensible and identical to that produced with n45lsdazsnd9642f2mxrxwvc9a173pc8-osmium-tool-1.11.1 currently included in NixOS 20.03)

Ship it! :shipit:

@marsam marsam merged commit 68e60f8 into NixOS:master May 4, 2020
17 checks passed
17 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c241a4c"; rev="c241a4c58fb795cfa103cc58f8a71a7f4a593b9e"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c241a4c"; rev="c241a4c58fb795cfa103cc58f8a71a7f4a593b9e"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c241a4c"; rev="c241a4c58fb795cfa103cc58f8a71a7f4a593b9e"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c241a4c"; rev="c241a4c58fb795cfa103cc58f8a71a7f4a593b9e"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c241a4c"; rev="c241a4c58fb795cfa103cc58f8a71a7f4a593b9e"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c241a4c"; rev="c241a4c58fb795cfa103cc58f8a71a7f4a593b9e"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c241a4c"; rev="c241a4c58fb795cfa103cc58f8a71a7f4a593b9e"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
osmium-tool, osmium-tool.passthru.tests on aarch64-linux Success
Details
osmium-tool, osmium-tool.passthru.tests on x86_64-darwin Success
Details
osmium-tool, osmium-tool.passthru.tests on x86_64-linux Success
Details
@r-ryantm r-ryantm deleted the r-ryantm:auto-update/osmium-tool branch May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.